Get rid of email.Message, use MultiDict instead about aiohttp HOT 22 CLOSED

+10 on this.
It was the first remark I've did myself when I've started to use aiohttp.
About Multidict implementation, I've found a lot in Python librairies, like in werkzeug, django, python-ldap...

from aiohttp.

@GMLudo please take a look on https://github.com/KeepSafe/aiohttp/blob/master/aiohttp/multidict.py and feel free to blame if you will find the implementation doesn't satisfies your requirements.

from aiohttp.

At first look, it's ok for me.
I will test when it will be implemented in aiohttp classes.

from aiohttp.

@asvetlov do you work on this task?
I have some free time, I can integrate multidict.

from aiohttp.

@fafhrd91
I'll be busy for next two days, please feel free to move forward.

from aiohttp.

@asvetlov Probably HttpResponse class should not inherit from http.message.HttpMessage class. We can add 'headers' attribute to response, but we need case insensitive multidict

from aiohttp.

@fafhrd91 do you really need for case insensitive one?
Can just keeping upper-case header names satisfy your requirements?

from aiohttp.

I can implement CIMultiDict and CIMutableMultidict next Monday. Sorry, tomorrow I'll probably not have enough free time.

from aiohttp.

I'll implement. And we need immutable only

from aiohttp.

@fafhrd91 I agree with not inheriting HttpResponse from http.message.HttpMessage

from aiohttp.

ok

from aiohttp.

Also I worry a bit about several Request/Response classes.
We have Response and HttpResponse for example.
High-level server API will need for own Request/Response pair (see aiorest).
That's a mess. Probably good documentation can help.

Ideally I would like to rename:

• HttpRequest/HttpResponse to ClientRequest/ClientResponse
• Request/Response to RequestImpl/ResponseImpl (they are part of low-level API)
• Upcoming high-level pair should be ServerRequest and ServerResponse.

We can keep existing names as aliases to renamed classes.
Thoughts?

from aiohttp.

I like ClientRequest/Response but I don't like RequestImpl.—
Sent from Mailbox

On Sat, Jun 7, 2014 at 12:12 PM, Andrew Svetlov [email protected]
wrote:

Also I worry a bit about several Request/Response classes.
We have Response and HttpResponse for example.
High-level server API will need for own Request/Response pair (see aiorest).
That's a mess. Probably good documentation can help.
Ideally I would like to rename:

• HttpRequest/HttpResponse to ClientRequest/ClientResponse
• Request/Response to RequestImpl/ResponseImpl (they are part of low-level API)

• Upcoming high-level pair should be ServerRequest and ServerResponse.
  We can keep existing names as aliases to renamed classes.
  Thoughts?

  Reply to this email directly or view it on GitHub:
  #62 (comment)

from aiohttp.

Choose something what you like -- but keep in mind that after adding high level server API we'll need to distinguish current low-level server request/response and upcoming high-level ones.

IIRC we have agreement that current server code will be saved (maybe with some minor changes) and we'll add high-level abstraction on top of current server code.

from aiohttp.

fixed in @6d3050193d31a40e4236ad5e08f0a805aeb6fa06

from aiohttp.

I also would like to use MultiDict in server code.
@fafhrd91 do you have objections?

from aiohttp.

-1 right now. i need to see specs and concerns of ServerRequest/ServerResponse code first. let’s work on this later.

On Jun 8, 2014, at 8:36 AM, Andrew Svetlov [email protected] wrote:

I also would like to use MultiDict in server code.
@fafhrd91 do you have objections?

—
Reply to this email directly or view it on GitHub.

from aiohttp.

Ok. Thus we are ready for 0.8 release?

from aiohttp.

Mostly ready, I need to fix logging bug, then I'll make release.—
Sent from Mailbox

On Sun, Jun 8, 2014 at 9:48 AM, Andrew Svetlov [email protected]
wrote:

Ok. Thus we are ready for 0.8 release?

Reply to this email directly or view it on GitHub:
#62 (comment)

from aiohttp.

i've decided to migrate to multidict while working on logging code

from aiohttp.

Looks like great change! Thank you.

from aiohttp.

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

from aiohttp.