airdcpp-web / airdcpp-webui Goto Github PK

View Code? Open in Web Editor NEW

18.0 9.0 8.0 19.92 MB

Web User Interface for AirDC++ Web API

Home Page: https://airdcpp-web.github.io

License: MIT License

JavaScript 7.70% CSS 3.03% TypeScript 88.96% EJS 0.31%

airdcpp react webapi webui websocket

airdcpp-webui's Introduction

airdcpp-webui

This package should be used directly only for development purposes; end users will get it through other projects, such as AirDC++ Web Client. Normal feature request and bug reports should also be posted on AirDC++ Web Client's issue tracker.

AirDC++ Web UI written in Javascript. Communicates with AirDC++ Core via AirDC++ Web API.

Installing dependencies

You must have Node installed before continuing. It's also recommended to ensure that your version of Node comes with npm 3 or newer (check with npm -v) as older versions may cause errors during the build process. See this guide for upgrading instructions.

The following commands should be run in the main directory of the cloned repository.

Install dependencies:

$ npm install

Production build

Run the command

$ npm run build

Running the integrated development server

The integrated server connects to AirDC++ Web API through the default port 5600. When the server is running, open your browser and navigate to http://localhost:3000

You may start the server by running

$ npm start

Changes made to the source will be updated instantly to the browser while the server is running (there is no need to run the build command).

airdcpp-webui's People

Contributors

Stargazers

Watchers

Forkers

rundgong egoitzro txc peps1 venompie h0od wiejakp petrovi4

airdcpp-webui's Issues

Security: Fix package version

$ npm audit
                                                                                
                       === npm audit security report ===                        
                                                                                
# Run  npm update handlebars --depth 5  to resolve 2 vulnerabilities
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Arbitrary Code Execution                                     │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ jest-cli [dev]                                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ jest-cli > @jest/core > @jest/reporters > istanbul-reports > │
│               │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1324                            │
└───────────────┴──────────────────────────────────────────────────────────────┘


┌───────────────┬──────────────────────────────────────────────────────────────┐
│ High          │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ jest-cli [dev]                                               │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ jest-cli > @jest/core > @jest/reporters > istanbul-reports > │
│               │ handlebars                                                   │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/1325                            │
└───────────────┴──────────────────────────────────────────────────────────────┘


found 2 high severity vulnerabilities in 896148 scanned packages

Making types installable via yarn or npm

Hello, could you consider making the types independently installable via DefinitelyTyped so that integrating apps can benefit from the latest changes?

If client has unsupported language then webUI hangs on loading spinner

Open the webUI with an invalid language. Either use an unsupported language or change i18nextLng in local storage to ie nb-NO (norwegian)

This throws a js error in the console and the webUI never loads.

Error: Cannot find module './nb/webui.main.json' .*$:32
    r .*$:32
    o .*$:27
    ajax LocalizationService.ts:22
    value index.js:82
    value index.js:75
    value BackendConnector.js:160
    value BackendConnector.js:226
    value BackendConnector.js:199
    forEach (index):262
    value BackendConnector.js:198
    value BackendConnector.js:205
    value i18next.js:210
    o i18next.js:290
    value i18next.js:296
    s i18next.js:149
i18next::backendConnector: loaded namespace main for language en

Since this blocks the webUI completely I think it should be changed so the fallback language is used both when the service can not detect the language but also if it is an unsupported language.

Also since you are familiar with the translation here. Norwegian identifies with no and nb, or even nn for another variant of the language which one may want to use at least until both translation variants exist. Should this be reported here, in i18next-browser-languagedetector or somewhere else?