ajitsing / sherlock Goto Github PK

So I updated the SDK to 26 in my launcher app and a crash accurs telling me the activity does not exist and if I implemented it in my Manifest. So I thought about it and made a new activity that extends CrashListActivity and it opens but nothing shows. Notifications do not appear either to indicate crash. whats happening...

Is their a way to theme the list activity?

Sent from my Mi 5 using FastHub

crash.getId() return 1, then always 2
so every next crash after 2nd will open not proper report!

and reports from notification opens not proper crash details, too.

NOTE: issue can be reproduced only if crash happened in Application onCreate() or near it, i mean on app start

Hello,

It's a usual practice for libraries like this (that only exist for debug builds) to release a no-op version of the library that is completely empty, so that users of the library can use it in their app without worrying that the library is going to increase their release APK size, or cause any side effects in production. For an example see here: https://github.com/square/leakcanary

This can be fixed on the developers side by using an interface (for example see https://github.com/athkalia/Just-Another-Android-App/blob/8a5c677b2b0d0f2dcc123d40b770307a13786b64/app/src/main/java/com/example/tools/stetho/StethoTool.java in my project for introducing stetho only for debug builds), but it's much more convenient when fixed by the library

When detect error crash, is posible show a dialog with buttons (close,detaile, report) without notification?
Detaile -> open crash report
report -> open email for send a developer

After adding Sherlock.init(this) in Application, it shows fatal exception
NoClassDefFoundError on com.singhajit.sherlock.core.database.SherlockDatabaseHelper

com.singhajit.sherlock.crashes.activity does not exist
import com.singhajit.sherlock.crashes.activity.CrashListActivity;
^
1 error

does not exists when use releaseCompile('com.github.ajitsing:sherlock-no-op:1.0.2@aar')

maybe you can provide method Sherlock.openCrashListActivity(context); ?

Hello,

this is an interesting library, thanks for sharing! Unfortunately including Realm will be prohibitive for quite a few devs cause of its size. Also, enabling databinding just for the sake of including this library in a commercial project would be very difficult to justify.

Libraries should minimize dependencies like that to make it easier for developers to integrate them into projects. I would suggest rewriting it without these 2 components.

Cheers,
Sakis

Hi Ajit,

I tried implementing this lib in build.gradle in my app(as a dependency).

1. debugCompile('com.github.ajitsing:sherlock:1.0.4@aar') {
   transitive = true
   }
   releaseCompile('com.github.ajitsing:sherlock-no-op:1.0.4@aar')

2. Sherlock.init(this); in my application.

And also triggered Exception manually. As expected it created Notification. But on click of notification the Sherlock CrashActivity is not launching and it is crashing due Null pointer Exception. Can you please help on this at earliest?

Regards,
Vijay