ajsharp / warden-rspec-rails Goto Github PK

In some scenarios, I need to test a controller as an anonymous user. However, I'm getting this error if the method set_user is not called.

it 'works' do
  get :index
end

NoMethodError:
       undefined method `cookies' for {}:Hash

When I set a user everything is working properly:

it 'works' do
  warden.set_user("user_id", User.first.id)

  get :index
end

Is there something I'm missing? How is it supposed to test a private controller using an anonymous user?

warden.authenticate! behaves differently in rails 5.

I tracked down the reason to this commit: rails/rails@50176b5 (and this line).

The above change changes the behavior of @controller.send(:performed?) return value here.

performed? is called after the action is processed.

You can see here that prepare! which is an alias of to_a is called on the response in the same way more or less in rails 4 & 5.

However, In rails 5 on prepare! it also marks the response as committed. This affects the performed? outcome as I already mentioned, which in turns affects the conditional in _catch_warden.

Can you give me some insight on why we want to check whether the controller has performed or not?
To my understanding, the change in behavior is more of a bug fix. I want to make a PR on this but need some help.

See this line.

What is the rationale behind this? I want to test certain authentication checks in my controller specs, but this behavior throws me off, because the controller code after my warden.authenticate! calls fails if it is executed without a valid user (which it does not expect due to that guard statement).

I'm not sure whether this gem is maintained, but it was raising an error for me recently when attempting to ruby 3.0.

The process(*) method here needs to change to process(*, **) to account for ruby 3 arg syntax changes:
https://github.com/ajsharp/warden-rspec-rails/blob/master/lib/warden/test/controller_helpers.rb#L16
https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

This is an issue similar to:
rails/rails-controller-testing#69

I did exactly as the README instructed and ran my tests and this is the error I received.

It seems it's not being loaded but not sure what should be required and where.

Thank you.