akecel / makefiles-runner Goto Github PK

Hey, awesome idea for a VSCode extension, I just have one small "problem" which is that it doesn't recognize my commands sometimes because the extension requires commands to have : ## (with exactly one space). I'm not a Makefile expert but as far as I know this is not required, just a common practice.

Would it be an idea to make this format optional, perhaps the parser can be configurable 100%? Or the "condition" for a line being a command it can boiled down to something like:

if (/^[a-z]+:($|[^=])/.match(line)) { ... }

Right now the command list only rebuilds on VSCode reload.

Is your feature request related to a problem? Please describe.
We don't have the best internal discipline around keeping the commands in our Makefile in any kind of meaningful order, meaning it would be easier to find a command in the extension's list if that list was sorted from A-Z. I could see this being an extension setting someday, but I wonder what you'd think of making it the default instead of showing the same ordering as in the Makefile.

Describe the solution you'd like
For the command list to be alphabetically sorted.

Describe alternatives you've considered
Manually sorting our Makefile commands and trying to maintain that ordering over time.

Additional context
N/A

I was looking at the source code of this and noticed the usage of workspace.rootPath, which has been deprecated. Thought I'd share this so it can be updated before it is removed in a future version of VS Code.