Giter VIP home page Giter VIP logo

dicon's Issues

API Document

There are no api documentation...
Needs api documents.

add error to constructor return values

add error to constructor return values.

now:

func NewDependency() Dependency {
    return &dependency{}
}

expected:

func NewDependency() (Dependency, error) {
    return &dependency{}, nil
}

mock can't compile when mock method return values is empty

generating mock code can't compile when mock method return values is empty.

environment

go version go1.9.2 darwin/amd64
dicon revision: 81c5355

steps to reproduce

  1. setup
go get -u github.com/akito0107/dicon
cd $GOPATH/src/github.com/akito0107/dicon
git checkout 81c5355d6f1591b8cc4ed81deba7a58e4a2b4051
go build
  1. create files

test/container.go

package test

// +DICON
type Container interface {
	A() (A, error)
}

test/a.go

package test

type A interface {
	F()
}

type a struct{}

func (a *a) F() {}

func NewA() (A, error) {
	return &a{}, nil
}
  1. generate mock
./dicon generate-mock --pkg test

output

expected

mock/dicon_mock.go

// Code generated by "dicon"; DO NOT EDIT.

package mock

type AMock struct {
	FMock func()
}

func NewAMock() *AMock {
	return &AMock{}
}

func (mk *AMock) F() {
	mk.FMock()
}

actual

mock/dicon_mock.go

// Code generated by "dicon"; DO NOT EDIT.

package mock

type AMock struct {
	FMock func()
}

func NewAMock() *AMock {
	return &AMock{}
}

func (mk *AMock) F() {
	return mk.FMock()
}

generating mock method arguments is incorrect

generating mock method arguments is incorrect.

environment

go version go1.9.2 darwin/amd64
dicon revision: 81c5355

steps to reproduce

  1. setup
go get -u github.com/akito0107/dicon
cd $GOPATH/src/github.com/akito0107/dicon
git checkout 81c5355d6f1591b8cc4ed81deba7a58e4a2b4051
go build
  1. create files

test/container.go

package test

// +DICON
type Container interface {
	A() (A, error)
}

test/a.go

package test

type A interface {
	F(b, c int) int
}

type a struct{}

func (a *a) F(b, c int) int {
	return 0
}

func NewA() (A, error) {
	return &a{}, nil
}
  1. generate mock
./dicon generate-mock --pkg test

output

expected

mock/dicon_mock.go

// Code generated by "dicon"; DO NOT EDIT.

package mock

type AMock struct {
	FMock func(a0, a1 int) int
}

func NewAMock() *AMock {
	return &AMock{}
}

func (mk *AMock) F(a0, a1 int) int {
	return mk.FMock(a0, a1)
}

actual

mock/dicon_mock.go

// Code generated by "dicon"; DO NOT EDIT.

package mock

type AMock struct {
	FMock func(a0 int) int
}

func NewAMock() *AMock {
	return &AMock{}
}

func (mk *AMock) F(a0 int) int {
	return mk.FMock(a0)
}

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.