aklomp / shrinkpdf Goto Github PK

Release version 1.1 when the changes since 1.0 have stabilized.

After issue #1 added support for running shellcheck in CI, it seems like the script has a few issues. Fix/ignore all of them.

Add a CI pipeline using GitHub Actions.

• Run shellcheck on every commit to check for common shell-scripting pitfalls.
• Run the actual script by generating a quick PDF file and trying to shrink it. Maybe converting the README.md to PDF with pandoc or something similar.

On a machine where the locale is set to something not equivalent to ASCII, the call to awk in get_pdf_version() will throw the following error:

awk: cmd. line:1: (FILENAME=- FNR=1) warning: Invalid multibyte data detected. There may be a mismatch between your data and your locale. 

This can be fixed by forcing the C locale by prepending the call to awk with LC_ALL=C.

Reported and fixed by Laurent MUGNIER.

Hi there,

I have packaged shrinkpdf for Gentoo:
https://git.sthu.org/?p=shuber-gentoo-overlay.git;a=tree;f=app-text/shrinkpdf;h=66b372e6254652314ed663b3bc180b1135e1cdec;hb=HEAD

Since some commits since last release 1.1 from Jun 2022 appear quite important, I would like to ask whether or when you would tag a new release. This would allow me to provide a Gentoo ebuild not being version 9999, but a specific commit with a proper version name.

Best
Stefan

CI actions should also be run for pull requests.

Hi

I've used a personnal script with more or less same feature. As your code looks better I'll change to it :)

A feature miss in my use cas overwrite option. In many case I assume optimization should be done on the original file. Is it possible to add this behavior ?

Thanks

Currently, the script has the usage signature shrinkpdf.sh [-g|-h] <infile> [outfile] [res]. The mix of positional arguments and option arguments is a bit messy. Let's replace the optional positional arguments with option flags.

Proposal for the new usage signature: shrinkpdf [-g|-h] <infile> [-o <outfile>] [-r res]

This should be a bit more future proof if new features are added.

Hi

Could be nice to provide a simple debian packaging :)

Experiencing Segmentation Fault (core dumped) error for some PDFs. How to solve?

Adding support for such case would be useful, otherwise handling manually a temporary file is needed

HI @aklomp thanks for this library
Any way/any plan to be able to use absolute url as PDF input file?

So we can use this as API without 'upload'/store the PDF at same location first.

Thanks!

Hello

In try to provide a package version, could be nice to allow configuration.

Following debian logic could be an /etc/default/package file as default configuration.
Followign FHS could be an /etc/shrinkpdf file to overwrite configuration

I've tried to do it with 86bad6d
But if we want not be debian centric, should be a test on /etc/shrinkdpf if present.