I started updating some dependencies and noticed that v0.2.0 is available. Congrats on the new release. It’s great to see that you are still maintaining the project.

I tried finding some information about the changes, but I couldn’t find any. Before pushing the upgrade to production, it would be useful to know what has changed. Would it be possible to have a changelog of sorts? (Personally, I have found https://keepachangelog.com/en/1.0.0/ to be a good guide.)

The code seems to assume ascii file name characters, even though with Django media, the filenames typically originate with users who upload files.

This error is with Django 1.8, Python 2.7, and macOS.

The error is in stdout.write, but there may be other issues as the u'' convention is not used in filename-related code. (from future import unicode_literals might be a good idea).

File "python2.7/site-packages/django_unused_media/management/commands/cleanup_unused_media.py", line 43, in handle
    self.stdout.write(f)
UnicodeDecodeError: 'ascii' codec can't decode byte 0xcc in position 23: ordinal not in range(128)

To keep code clean, it's better to add isort, flake8, pydocstyle or similar tools to CI.

The command cleanup_unused_media should not write anything into standard output when verbosity is 0.

Action triggered by hitting Enter without input should be uppercase, which should show uppercase N instead of Y.

As is:

$ .../manage.py  cleanup_unused_media
These files will be deleted:
screenshots/Screen_Shot_2017-01-16_at_10.56.29.png
Are you sure you want to remove 1 unused files? (Y/n)

Should be:

$ .../manage.py  cleanup_unused_media
These files will be deleted:
screenshots/Screen_Shot_2017-01-16_at_10.56.29.png
Are you sure you want to remove 1 unused files? (y/N)

Hi,

The command cleanup_unused_media just figures out used files as deletable an deletes them.

Thank You.

My environment:
Django 1.11.13
django-unused-media 0.1.11
Windows 7
python 3.4

It would be very helpful if the command would have a dry-run mode.

I am having troubles installing version 0.1.13.
If I do pip install django-unused-media I get version 0.1.12 installed.
If I specify the version explictly, I get the following error:

$ pip install django-unused-media==0.1.13
Collecting django-unused-media==0.1.13
  Could not find a version that satisfies the requirement django-unused-media==0.1.13 (from versions: 0.1.0, 0.1.1, 0.1.2, 0.1.3, 0.1.5, 0.1.6, 0.1.7, 0.1.8, 0.1.9, 0.1.10, 0.1.11, 0.1.12)
No matching distribution found for django-unused-media==0.1.13

First, thank you for this nice package!
I have some directories and files in media/ accessed from django-filebrowser (file cloud in admin). My shell gives me command history, so I always add as many --exclude arguments as I need. But my project will be used by other people, who can miss some files and some logic will be broken. I believe a good solution is to have a list in settings.py containing strings - elements of --exclude.

Hiyo..

noticed this removed thumbnails and such for my projects.. So I decided to extend this to support the variations field that django-stdimage uses..

#5

Feel free to merge

Cheers!

Just noticed if I used a file setting in constance, django-unused-media will delete it. The process to use a file setting is described here.

Wondering if there's a workaround, or worth patching? (I'm happy to write the patch if you'd be willing to accept it!)

Cheers,

David

Trying to install with Django 1.11 actually uninstalls that version, and installs 1.10.7 instead.

I have a model on which the default manager filters out some instances, which causes the media matching the filtered rows to be treated as unused. This is problematic.

Using _base_manager rather than objects to find model instances should fix this problem, and it fixes the potential bug around assuming that every model has a default manager called objects.

With large databases and many files there can be a delay between getting the used files from the database and all the files from disk. Inbetween a file may have been uploaded, which will then be deleted by the script. While this is an edge case and not very likely to happen, I would suggest adding an option (or making it default) to only remove files that have not been modified for some length of time, for example a couple of minutes or an hour.

If you like this idea I'll be happy to prepare a pull request adding this functionality, but before I do that I am wondering what your thoughts are.

There's a potential race between an application writing a new file and updating the database, such that a media file that has not yet been recorded in the database is treated as unused:

1. Application writes file to media storage
2. Scan finds file in storage
3. Scan doesn't find file in database
4. Application writes model referring to file to the database

The window between 1 and 4 will usually be short, but a very fast scan for unused files or transactionality-related delays in the database could make this more likely to happen.

Supporting an option to ignore files that were created within some time period can make it arbitrarily difficult to cause this problem. For instance if any file that's less than one day old is ignored, it's virtually impossible for this to happen because it's difficult to imagine a reasonable application taking a day to complete a database write. However, making this a user-accessible option would allow users to decide an appropriate interval for themselves in making a tradeoff between prompt pruning of unused files and potential data loss.

I'm unsure how feasible this is to do in a portable way, though- I haven't looked into it in any detail.

I just gave a try to django-unused-media today.
It works perfectly out of the box with my media files hosted on my own workstation.

But, in production, I use AWS S3 to store media and static files into a bucket.
And I got this exception : NotImplementedError: This backend doesn't support absolute paths.

Is AWS S3 supported?
Or I am missing something?

Thanks!

hi

i recently installed this on a django project i'm working on to do cleanups of my unused media files. I ran the cleanup_unused_media command with my virtualenv enabled and i got the following result. I tried it with

python manage.py cleanup_unused_media

Traceback (most recent call last):
  File "manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 385, in execute_from_command_line
    utility.execute()
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 377, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django/core/management/base.py", line 288, in run_from_argv
    self.execute(*args, **options.__dict__)
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django/core/management/base.py", line 338, in execute
    output = self.handle(*args, **options)
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django_unused_media/management/commands/cleanup_unused_media.py", line 32, in handle
    unused_media = get_unused_media(options.get('exclude') or [])
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django_unused_media/cleanup.py", line 91, in get_unused_media
    used_media = get_used_media()
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django_unused_media/cleanup.py", line 43, in get_used_media
    for f in _get_file_fields():
  File "/home/dev/.virtualenvs/TestProject/local/lib/python2.7/site-packages/django_unused_media/cleanup.py", line 29, in _get_file_fields
    for f in m._meta.get_fields():
AttributeError: 'Options' object has no attribute 'get_fields'

i tried running it with the option --noinput enabled but i got the following error

python manage.py cleanup_unused_media --noinput
Usage: manage.py cleanup_unused_media [options] 

Clean unused media files which have no reference in models

manage.py: error: no such option: --noinput

Is there a missing option for this which is why it's not running? I've installed django_unused_media in my INSTALLED_APPS as well. Thanks.

Edit: Forgot to note that i'm using Django 1.7.

I came across this project after some quick googling (via this question), and it solved my problem.

Just want to say that I really appreciate you sharing and maintaining it ❤️

Although 0.1.13 have been released to pypi, corresponding tag is missing on github.

Hi,

when adding --noinput to management command it still asks if we want to remove following items:

$ .../manage.py  cleanup_unused_media --noinput
These files will be deleted:
screenshots/Screen_Shot_2017-01-16_at_10.56.29.png
Are you sure you want to remove 1 unused files? (Y/n)

Btw, i'm using Django 1.10.5 and Python 2.7.5.

• If MEDIA_ROOT declared as absolute path, it deleting everything in MEDIA_ROOT
• remove_empty_dirs should be optional command argument
• Incorrect output in confirmation (y)
• Django 1.11 should be presented as supporting version because the app works well with it

My PR with fixes #9

from #10:
remove_empty_dirs should be optional command argument

When trying to override default values of --minimum-file-age e.g

python3 manage.py cleanup_unused_media --dry-run  --minimum-file-age 42

The tool fails with the error

  File "/usr/local/lib/python3.6/site-packages/django_unused_media/cleanup.py", line 59, in get_all_media
    if file_age < minimum_file_age:
TypeError: '<' not supported between instances of 'float' and 'list'