albertlwolf / rogue-code Goto Github PK

Hello 
There is a problem with the library when using also a Servo library.
It wont compile delivering a message of a array double used on the 2 libraries
To test this issue just test this simple sketch

#include <Tone.h>
#include <Servo.h>

Tone tone1;

void setup()
{
  tone1.begin(13);
  tone1.play(NOTE_A4);
}

void loop()
{
}

The error point to TIMER1_COMPA_vect that is doubled on the same cpp files of 
which library

Thanks

The current version will not compile using the Arduino 1.0 beta release. 

Modifying Tone.cpp as follows will fix this problem:
#if ARDUINO > 22
#include "Arduino.h"
#else
#include <wiring.h>
#include <pins_arduino.h>
#endif

Moreover...Google Code is going to close!

NewSoftSerial is now part of Arduino 1.0 under SoftwareSerial 
<http://arduino.cc/en/Reference/SoftwareSerial>

Examples should updated for Arduino 1.0

#include <RogueMP3.h>
#include <SoftwareSerial.h>

SoftwareSerial rmp3_serial(6, 7);

and the RogueMP3 needs a small update as Serial.write() now returns size_t 
instead of void. Changes are needed on line 155 in RogueMP3.h and line 518 in 
RogueMP3.cpp

Hi,

i only need a software pwm for one part of my program and would like to disable 
it again after that to get back the full processing power. But after
    SoftPWMBegin();

has been run there seems to be no way back... could you add an command which 
would unload all softpwm routines again after     SoftPWMBegin(); has run 
again. 

thanks in advance

What steps will reproduce the problem?
1. include tone library on a Arduino leonardo board.
2. #include <Tone.h>
3.

What is the expected output? What do you see instead?
A proper compile is expected. Instead there is an error compiling.

/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp: In member function 
'void Tone::begin(uint8_t)':
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:149: error: 'TCCR2A' 
was not declared in this scope
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:150: error: 'TCCR2B' 
was not declared in this scope
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:151: error: 'WGM21' 
was not declared in this scope
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:152: error: 'CS20' 
was not declared in this scope
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp: In member function 
'void Tone::play(uint16_t, uint32_t)':
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:256: error: 'TCCR2B' 
was not declared in this scope
/Users/Alexander/Documents/Arduino/libraries/Tone/Tone.cpp:314: error: 'OCR2A' 
was not declared in this scope



What version of the product are you using? On what operating system?
Arduino 1.0.3 with a Arduino Leonardo on Mac OSX 10.8.3

Please provide any additional information below.

I have added "#include <Arduino.h>"  to the Tone.ccp file.

The Libary doesn't work for the Arduino 1.0.1 Version.
It won't compile and produces many scope errors.

How can this be fixed and updated?

I spent the last few days struggling to make that great lib work on ATtiny2313 
and finally succeded :-)

The code is available in the following post on the Arduino forums. You might be 
interested in including it the next relase (note it also includes the edits 
made for Teensy 3.0 on pjrc.com) :

http://forum.arduino.cc/index.php?topic=83774.msg2150255#msg2150255

Keep on the good work,

Vicne

Pin number 0 can not be used by this library.

Line number 158 of SoftPWM.cpp uses case pin<0 and case pin>0 but does not 
account for the case of pin=0.

If held low, the 7 bit trigger repeats automatically.  This is undesired.

Trigger should fire, then wait until released.

(Seeing problem on the Mega 2560 using Arduino 1.0.3 IDE)
Reproduction:
1. Call SoftPWMBegin() in setup
2. Call analogWrite(9, x) with varying values for x
3. Only 0% or 100% duty cycles are output on the pin. There is no fading if you 
attach an LED.
4. All other hardware PWM pins I've tried worked fine

What steps will reproduce the problem?
1. Launch Arduino 0022
2. Select a SoftPWM example from the examples menu
3. compile or upload the example

The compiler complains about portOutputRegister not being defined.
which is defined in pins_arduino.h in this version of arduino.
I included the header file in SoftPWM.cpp and the example worked.

#if defined(WIRING)
 #include <Wiring.h>
#elif ARDUINO >= 100
 #include <Arduino.h>
#else
 #include <WProgram.h>
 #include <pins_arduino.h>
#endif

P.S. Thanks for a nice softpwm library

What steps will reproduce the problem?
1. Trying to compile any Attiny85 code including this library

What is the expected output? What do you see instead?
A functional Attiny85 with working software PWM

What version of the product are you using? On what operating system?
Ubuntu Linux and Arduino IDE 1.5.5
Arduino Leonardo as ISP
(The set is fully functioning and working every day)

Please provide any additional information below.
This is the output when trying to compile. It probably is a compatibility 
problem.

/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp: In function ‘void 
SoftPWMBegin(uint8_t)’:
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘TIFR2’ was 
not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘TOV2’ was 
not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘TCCR2B’ 
was not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘CS21’ was 
not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘TCCR2A’ 
was not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘WGM21’ was 
not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘OCR2A’ was 
not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘TIMSK2’ 
was not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:156: error: ‘OCIE2A’ 
was not declared in this scope
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp: In function ‘void 
SoftPWMSet(int8_t, uint8_t, uint8_t)’:
/home/john/sketchbook/libraries/SoftPWM/SoftPWM.cpp:205: error: ‘TCNT2’ was 
not declared in this scope





I am working on this project:
http://www.instructables.com/id/Attiny85-as-a-StepDir-Stepper-Motor-Controller/

And you library will change the world! It is needed for microstepping ability.


Thank you for your time...

SoftPWM completes each pulse (for PWM compatibility) before starting a new 
pulse.  This causes multiplexed displays to have "ghosting" effects where the 
pwm from the previous (or multiple) scan lines to be carried over.

When multiplexing pins on a matrix display, the PWM pulse needs to be synced 
with the scan line.

A forced pulse start would be recommended.

The ability to synchronize tones with an external signal is extremely critical 
in some applications.  I've attached a patch to the Tone Library that permits 
this functionality by calling a new "sync" routine from an interrupt.  A simple 
usage example follows:

---
Tone tone1;

void setup(void)
{
  tone1.begin(OUTPUT_PIN);
  tone1.play(FREQUENCY_OUT);
  attachInterrupt(0, sync_risingedge, RISING);
}

void sync_risingedge(void)
{
  tone1.sync();
}

void loop(void)
{
}

---

What steps will reproduce the problem?
1.include tone library on arduino UNO
2. including #include <Tone.h>
3.

What is the expected output? What do you see instead?

Arduino: 1.5.4 (Windows NT (unknown)), Board: "Arduino Uno"

C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp: In member function 
'void Tone::begin(uint8_t)':
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:121: error: 
'bitWrite' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:123: error: 
'digitalPinToPort' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:123: error: 
'portOutputRegister' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:124: error: 
'digitalPinToBitMask' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp: In member function 
'void Tone::play(uint16_t, uint32_t)':
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:198: error: 
'OUTPUT' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:198: error: 
'pinMode' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:294: error: 
'bitWrite' was not declared in this scope
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp: In member function 
'void Tone::stop()':
C:\Users\Edoardo2\Documents\Arduino\libraries\Tone\Tone.cpp:361: error: 
'digitalWrite' was not declared in this scope




What version of the product are you using? On what operating system?

Arduino 1.5.4 on Windows 8

Please provide any additional information below.
I have added "#include <Arduino.h>"  to the Tone.ccp file.

Configuration file settings are read in after loading temporary settings.  
Net effect is that temporary settings will have the previous value loaded 
initially.

----
Example:
Existing configuration:
O1
V16
B0

UMP3.CFG:
O0
V40
B255

After first power on with this configuration file:

PC O reports 1 (expected 0)
PC V reports 16 16 (expected 40 40)
PC B reports 0 (255)

----

Solution: move configuration read before loading temporary settings.

ummc.sync() - and presumably the sync on the rMP3 and uMP3 - will halt code if 
a sync is not successful (no device present).

A timout with error would be handy especially if people are stingy with 
debugging info in their code.