albinotonnina / parcel-plugin-inlinesvg Goto Github PK
View Code? Open in Web Editor NEWParcel plugin to support inline SVG
Home Page: https://parcel-inlinsvg.now.sh/
License: MIT License
parcel-plugin-inlinesvg's People
Contributors
Stargazers
Watchers
Forkers
nlemoine nihiluis demoorjasper erquhart tkh44 ciaoben skalt ascorbic contagious06 cybolic shulamyt lightricks bung87parcel-plugin-inlinesvg's Issues
Includes path string (looks like plugin is bypassed)
OS: MacOSX 10.13.4
Node: v10.3.0
Parcel: 1.8.1
Good day, couldn't make plugin work. Require and import resolves with path strings, also tried to run example from this repo, same thing.
npm run nexample:
<body>
<div id="demo"></div>
<script src="/example.239abad7.js"></script>
<span>/chrome.93807089.svg</span>
<span>[object Object]</span>
<span>[object Object]</span>
<span>/edge.42ce3460.svg</span>
<span>/opera.8281208b.svg</span>
<span>/explorer.54a685bf.svg</span>
<span>/dummy.9d98d980.svg</span>
</body>Action required: Greenkeeper could not be activated 🚨
🚨 You need to enable Continuous Integration on all branches of this repository. 🚨
To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.
Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.
If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.
Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.
Cannot seem to get it to work
I've studied both your examples but cannot figure out why your examples receive a SVG string from the import, while I always get URLs. I have the plugin in my dependencies and import the SVG file with a relative path.
Would you be so kind an take a minute to look at this minimal example:
git clone https://github.com/silverwind/inlinesvgtest
cd inlinesvgtest
npm i
npm startThis example should output a undesired /dist/03b8341b6ec324aad741016911ea1ec9.svg.
[Question] This plugin export the file if it's too big?
Question
This plugin export the file if it's too big?
Cannot read property 'env' of undefined
version issue
I just find that v1.0.0 is between v0.0.13 and v0.0.14. Why?
which version should I use now? v1.0.0 with the higher version number or v0.0.14 with the newer upload date. I guess that 1.0.0 is a mistake but I'm not sure if npm will allow you to delete it.
update: It seems to be not easy. https://stackoverflow.com/questions/36927974/how-to-delete-an-npm-package-from-the-npm-registry
Add Usage section in readme
How exactly should this plugin be used? What pain point does it solve? Thanks!
`npm run example fails
npm run example fails with "Cannot read property 'rootDir' of undefined", after parcel restarts three times until it launches the server:
$ git clone https://github.com/albinotonnina/parcel-plugin-inlinesvg.git
$ cd parcel-plugin-inlinesvg
$ npm install
$ npm run example
> [email protected] example /home/dandv/prg/parcel-plugin-inlinesvg
> cd example && npm start
> [email protected] start /home/dandv/prg/parcel-plugin-inlinesvg/example
> parcel index.html
Server running at http://localhost:1234
🚨 Cannot read property 'rootDir' of undefined
at new Asset (/home/dandv/prg/parcel-plugin-inlinesvg/example/node_modules/parcel-bundler/src/Asset.js:22:47)
at new InlineSvgAsset (/home/dandv/prg/parcel-plugin-inlinesvg/example/node_modules/parcel-plugin-inlinesvg/lib/asset.js:6:5)
at Parser.getAsset (/home/dandv/prg/parcel-plugin-inlinesvg/node_modules/parcel-bundler/src/Parser.js:86:12)
at Bundler.getLoadedAsset (/home/dandv/prg/parcel-plugin-inlinesvg/node_modules/parcel-bundler/src/Bundler.js:421:29)
at Bundler.resolveAsset (/home/dandv/prg/parcel-plugin-inlinesvg/node_modules/parcel-bundler/src/Bundler.js:413:17)The error went away after I changed the parcel version in package.json from 1.5.1 to 1.11.0.
Breaks CSS SVG backgrounds
This plugin doesn't inline into CSS which is fine, however it breaks existing SVG backround images.
In my CSS output I'm now getting reference to a non-existent JS file like so:
background-image: url('dist/my-svg.1234.js')
Cannot resolve dependency './filename.svg'
MacOSX 10.12.6
Node v10.0.0
Parcel 1.5.1
Tried installing this in my project and kept getting the above error. Cloned this whole repo and ran the example and get the same thing. It errors out on trying to import any svg file.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.