Giter VIP home page Giter VIP logo

awesomespotlightview's People

Contributors

aleksandrshoshiashvili avatar ergunkocak avatar fromf avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

awesomespotlightview's Issues

navigation controller

Have you been able to get it to focus directly on a navigation controller's bar button item?

Arrow not shown

Hello!

When i set enableArrowDown to true, no arrow appears. i just do spotlightView.enableArrowDown = true. Should i do something else?

Thanks and best regards,

Add Imageviews

Adding Imageview or images together with the text would be an awesome addition to the library. Thanks for the great library.

Not Updating in tableview

i am trying to use this library in tableview cells ,but its not updating correctly .
Please help me on this .
Thanks

Possible to enable user interaction within the spotlight?

Hi,

I'm loving this library and have been using it for my new app.

Currently, I spotlight a view I want my user to tap, but he has to tap twice in order to first dismiss the spotlight view. Is it possible to enable user interaction within the spotlight so I can eliminate the first tap?

Thank you,
Andrew

cutoutradius not showing

I'm trying to implement 0.2.0 on Swift 5. For some reason, the cutoutradius won't show. I'm I doing something wrong?

Feature Request : Extra margin parameter for circles

Hello,

First of of thanks a lot for such useful library 👍

For images "Circle" mode just covers the borders of image that would be great if we can define extra margin for the circle around the item so it can be bigger

Cheers

[Solved] X,Y issues in some cases.

Hello,

Thanks for the efforts on this beautiful library, I had to tweak it a little bit, as I needed to highlight an item on the UINavigationBar, but it only shows on the view below the NavigationBar, so what I did is

extension UIView {
    func getGlobalPoint(toView: UIView? = UIApplication.shared.delegate?.window!) -> CGPoint {
        return self.superview!.convert(self.frame.origin, to: toView)
    }
}

Then on any view I would define my CGRect according to the CGPoint of the view I want to spotlight

let currentWindow: UIWindow? = UIApplication.shared.keyWindow
let aRect = CGRect(origin: your_view.getGlobalPoint(toView: currentWindow?.superview), size: CGSize(width: your_view.width, height: your_view.height))
let spotlightView = AwesomeSpotlightView(frame: currentWindow!.frame, spotlight: [spotlight1])
currentWindow?.addSubview(spotlightView)

Here is the full code

let currentWindow: UIWindow? = UIApplication.shared.keyWindow
            
let aRect = CGRect(origin: your_view.getGlobalPoint(toView: currentWindow?.superview), size: CGSize(width: your_view.width, height: your_view.height))
            
let spotlight1 = AwesomeSpotlight(withRect: aRect, shape: AwesomeSpotlight.AwesomeSpotlightShape.roundRectangle, attributedText: NSAttributedString(string: " Some Display Text"), margin: UIEdgeInsets(top: 10, left: 10, bottom: 10, right: 10), isAllowPassTouchesThroughSpotlight: true)
            
let spotlightView = AwesomeSpotlightView(frame: currentWindow!.frame, spotlight: [spotlight1])
spotlightView.cutoutRadius = 8
spotlightView.delegate = self
currentWindow?.addSubview(spotlightView)
            
spotlightView.start()

I might open a PR with this tweak later, but I'm a bit busy, therefore I shared the solution here.

Thanks again for the efforts @aleksandrshoshiashvili

Setting spotlightMaskColor has no effect

Since the spotlightMask fill colour is only set on setupMask() which in turn is only triggered by init(frame there is no way to set the spotlight mask colour.

Pod Localizator bundlePath resolves wrong.

When installing as a pod.

Bundle.main.path(forResource: "AwesomeSpotlightViewBundle", ofType: "bundle") 

resolves incorrectly.

The bundle path should be as following:

if let bundlePath = Bundle(for: AwesomeSpotlightView.self).path(forResource: "Localizable", ofType: "plist") {

Podspecs not updated correctly

The podspecs for versions above 0.1.4 have not been updated correctly.

Versions 0.1.5 through to 0.1.8 are still pointing to the 0.1.4 release tag:

"source": {
    "git": "https://github.com/aleksandrshoshiashvili/AwesomeSpotlightView.git",
    "tag": "0.1.4"
  },

And version 0.1.8 does not correctly specify that it is to be build with Swift 4:

  "pushed_with_swift_version": "3.0"

You can see the published pod spec for 0.1.8 here: https://github.com/CocoaPods/Specs/blob/master/Specs/1/1/5/AwesomeSpotlightView/0.1.8/AwesomeSpotlightView.podspec.json

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.