• Add Zabbix 3.0 installation to setup.rb.
• Check with Vagrant.
• Check with Travis CI.
• Update code.

Currently we retry operations for different versions. For example:

We need to get Zabbix version after connection and use different implementations under the hood.

Hi,

I'm going to archive that project soon. I stopped using Zabbix years ago, and have other commitments that require my attention.

I don't think I can promote any fork to the "official" status in the current state. If you want me to do that, please work on #14. Specifically, CI and tests should be rock-solid. That will require a considerable amount of efforts, so please be prepared for that.

Otherwise, I will just archive that project and link to https://github.com/AlekSi/zabbix/network.

https://www.zabbix.com/documentation/2.2/manual/api/reference/apiinfo/version
This method is available to unauthenticated users and should be called without the auth parameter in the JSON-RPC request. Starting from Zabbix 2.4 the method will return an error if the auth parameter is given.

This is pretty annoying :(. Anyways, I'm open to working on this but wanted to get some thoughts together on the best way to approach it. I'd like to add an auth bool parameter to call.bytes and let it flex on using api.Auth[1], but this would require a slight change to all api methods that have been created. Thoughts?

[1]

func (api *API) callBytes(method string, params interface{}, auth bool) (b []byte, err error) {
        id := atomic.AddInt32(&api.id, 1)
        if auth {
                jsonobj := request{"2.0", method, params, api.Auth, id}
        } else {

                jsonobj := request{"2.0", method, params, "", id}
        }

Everything in the library works really well and it's easy to use. Only thing I'm missing is support for History objects. I wrote a simple version that does what I need, but I don't think it's complete enough to be added to master.

Couple things that need to be considered:

• This version handles all Values as strings. This was trivial to implement since the reflector works great. It would also be quite easy to add version that checks history parameter and passes proper struct type to reflector. Problem with this is that it would need to either return interface{} (or an actual interface with getters), which is not how rest of the system works and is ugly. Another version would be to have Value as interface{}, in which case it would need to be casted to proper value each time, which is even worse.
• I wrote a test, but since I'm using actual db and not an empty one it doesn't create new History object, thus it would fail on an empty db.

You can see the commit here: errnoh@9e6d3a1

When creating a host group using the api.HostGroupsCreate function I get

Error: -32602 (Invalid params.): Cannot set "internal" for host group "my.hosts.all".

I think the offending line is https://github.com/AlekSi/zabbix/blob/master/host_group.go#L20 where it needs to be marked as omitempty since it sounds like this might be a readonly field [1](but was erroneously noted otherwise if I'm reading the bug details correctly). If I call the api directly Api.Call("hostgroup.create", zabbix.Params{"name": hostgroup}) it works fine.

Using berngp/docker-zabbix container for testing if that helps ( zabbix ui shows 2.4.6 ).

[1]
https://support.zabbix.com/browse/ZBX-9017

The maintenance_status field of the host API should be returned as part of the host structure

`const (
Available AvailableType = 1
Unavailable AvailableType = 2

    Monitored   StatusType = 0
    Unmonitored StatusType = 1

    NotInMaint      StatusType = 0
    InMaint         StatusType = 1

)

// https://www.zabbix.com/documentation/2.2/manual/appendix/api/host/definitions
type Host struct {
HostId string json:"hostid,omitempty"
Host string json:"host"
Available AvailableType json:"available"
Error string json:"error"
Name string json:"name"
Status StatusType json:"status"
MaintenanceStatus StatusType json:"maintenance_status"

    // Fields below used only when creating hosts
    GroupIds   HostGroupIds   `json:"groups,omitempty"`
    Interfaces HostInterfaces `json:"interfaces,omitempty"`

}
`