alexanderjeurissen / ember-cli-history-mixin Goto Github PK

currently the following regex is used to determine if a route is a single resource:

  isSingleResource: Ember.computed.match('currentPath', /(?:^(?!.*s\b))(?:^(?!index)).*$/),

this regex checks if one of the following conditions is true:

• currentRouteName is not equal to index
• currentRouteName isn't plural (only checks if it doesn't end with an 'S')

however this regex breaks on routes such as: not-found because it
a. isn't equal to index
b. isn't plural

a simple check in the activeRoute computed property on the presence of the id property is a possible workaround that I'll implement soon.

as reported by @sn3p from LearningSpaces:

considering the following routes:

this.resource('learning_space', {
  path: '/spaces/:learning_space_id'
}, function () {
  this.resource('chapters', function () {
    this.resource('chapter', {
      path: '/:chapter_id'
    }, function () {
      this.resource('submissions', function () {
        this.resource('submission', {
          path: '/:submission_id'
        });
      });
      this.route('edit');
    });
  });
});

Go to a chapter and refresh.
Edit the chapter and press goBack.

results in the following error:

Uncaught Error: Assertion Failed: The route learning_space.chapters.chapter.index was not found

I'm getting an error that I have not yet been able to resolve, where I have a link to either another route, or a nested route, for example, either:

{{#link-to 'info.authors' class="item-link" eventName="tap"}}

or

{{#link-to 'authors' class="item-link" eventName="tap"}}

in this scenario, I'm getting the error:

Uncaught Error: More context objects were passed than there are dynamic segments for the route:

In the latest version of Ember and Ember-CLI, the following deprecation warning shows up during a build:

DEPRECATION: Addon files were detected in /home/mconaway/NetBeansProjects/undertow-client/node_modules/ember-cli-history-mixin/addon, but no JavaScript preprocessors were found for ember-cli-history-mixin. Please make sure to add a preprocessor (most likely ember-cli-babel) to in dependencies (NOT devDependencies) in ember-cli-history-mixin's package.json.

This should be fixable by just modifying the package.json.

Thanks for making this addon!