alexgurr / react-coding-challenges Goto Github PK

Hi i already asked this on Twitter but maybe you missed it or don't look that much in Twitter (can't blame you, neither do i) but i liked to have access to the solutions repo.
Thanks in advance!

Expected behaviour

Rocketship example should install and start successfully.

Actual behaviour

I could not start the application after a fresh install due to Cannot find module 'babel-core'. This is sub dependency of react-scripts. Using node v14.7.0.

I'm seeing this behaviour on

• Desktop
• Mobile
• N/A

OS

Mac OS

I'm not a dummy, so I've checked these

• I've run yarn / npm install.
• I'm using an up to date nodeJS version.
• My issue doesn't already exist
• I'm not on an M1 Mac, or if I am, I googled the issue first.

So how can we reproduce this?

• Checkout codebase and cd to rocket-ship
• npm install
• npm start

Hello, I couldn't find any option to send you an email to request the answers to the react challenge.
Can you please share them with me on [email protected]?

Hi!

Expected behaviour

I'd expect logins to succeed on https://www.solutions.alexgurr.com/

Actual behaviour

Seeing this on Chrome on OSX.

None of the challenges work without fixing dependency issues.

For example, this error happens when I yarn start the dark-mode with skip preflight check in a .env
"
./src/styles/_main.scss (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-5-1!./node_modules/postcss-loader/src??postcss!./node_modules/resolve-url-loader??ref--6-oneOf-5-3!./node_modules/sass-loader/dist/cjs.js??ref--6-oneOf-5-4!./src/styles/_main.scss)
Error: Node Sass does not yet support your current environment: OS X 64-bit with Unsupported runtime (88)
For more information on which environments are supported please see:
https://github.com/sass/node-sass/releases/tag/v4.14.1"

Expected behavior

yarn/npm install should install dependencies, it fails to happen on my computer, I found that the reason was my node version was 16, and it is not supported with the version of node-sass that this project uses which requires node version 14(https://github.com/sass/node-sass), once I changed my node version to 14.7.1 it started working but I think it should be mentioned in the readme which version of node to use.

I'm seeing this behavior on

• Desktop
• Mobile
• N/A

OS

macOS

I'm not a dummy, so I've checked these

• I've run yarn / npm install.
• I'm using an up to date nodeJS version.
• My issue doesn't already exist
• I'm not on an M1 Mac, or if I am, I googled the issue first.

Expected behaviour

Dependencies should install

Actual behaviour

Dependencies do not resolve after npm install
Error message:

rocket-ship git:(master) npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! Found: @babel/[email protected]
npm ERR! node_modules/@babel/core
npm ERR!   @babel/core@"7.12.3" from [email protected]
npm ERR!   node_modules/react-scripts
npm ERR!     react-scripts@"^4.0.3" from the root project
npm ERR!   @babel/core@"^7.12.3" from @svgr/[email protected]
npm ERR!   node_modules/@svgr/webpack
npm ERR!     @svgr/webpack@"5.5.0" from [email protected]
npm ERR!     node_modules/react-scripts
npm ERR!       react-scripts@"^4.0.3" from the root project
npm ERR!   9 more (babel-jest, babel-loader, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer @babel/core@"^7.13.0" from @babel/[email protected]
npm ERR! node_modules/@babel/preset-env/node_modules/@babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining
npm ERR!   @babel/plugin-bugfix-v8-spread-parameters-in-optional-chaining@"^7.13.12" from @babel/[email protected]
npm ERR!   node_modules/@babel/preset-env
npm ERR!     @babel/preset-env@"^7.12.1" from @svgr/[email protected]
npm ERR!     node_modules/@svgr/webpack
npm ERR!       @svgr/webpack@"5.5.0" from [email protected]
npm ERR!       node_modules/react-scripts
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I'm seeing this behaviour on

node: v15.12.0
npm: v7.7.1

• Desktop
• Mobile
• N/A

OS

I'm not a dummy, so I've checked these

• I've run yarn / npm install.
• I'm using an up to date nodeJS version.
• My issue doesn't already exist
• I'm not on an M1 Mac, or if I am, I googled the issue first.

So how can we reproduce this?

npm i

You wrote that we should change the icon to faSun in dark mode, but in your picture it shows faMoon. Small issue, have a good one!

Expected behaviour

Expect logins to succeed on https://www.solutions.alexgurr.com/.

Actual behaviour

Access been blocked just like what #29 stated, I've tested several times with each interval longer than 24hr to bypass the heroku issue yet still couldn't get in.

I'm seeing this behaviour on

• Desktop
• Mobile
• N/A

OS

Windows, Chrome

Expected behaviour

Unnecessary spelt correctly

Actual behaviour

Unecessary is currently spelt like this in the read me

I'm seeing this behaviour on

• Desktop
• Mobile
• N/A

OS

N/A

I'm not a dummy, so I've checked these

• I've run yarn / npm install.
• I'm using an up to date nodeJS version.
• My issue doesn't already exist
• I'm not on an M1 Mac, or if I am, I googled the issue first.

So how can we reproduce this?

Awesome ⭐⭐⭐⭐⭐

Provide a (link to a) minimal demo app showing the faulty behaviour.

Sweet ⭐⭐⭐⭐

Provide a concise code sample.

Good ⭐⭐⭐

Provide your own app and instructions how to reproduce the issue.

Meh ⭐⭐

Provide a code sample with a bunch of magic parameters which I need to interpolate by guessing to reconstruct the actual code.

Worst 💩

Say the source code can't be disclosed and refuse to provide any of the above. Expect this issue to be closed by a bunch of angry aliens 👽👽👽👽👽 that will hunt you down and 🔥 your 🖥. You've been warned 🚒.