Comments (3)
With the release of version 5.0 came some breaking changes, hence the major version bump. React's deprecation of findDOMNode in favor of a more declarative way of tracking refs requires this change moving forward in order for the component to maintain compatibility with React's StrictMode.
Check the docs for helpful examples along with React's ref forwarding API.
Note that findDOMNode has been deprecated in StrictMode. Unfortunately, react-tiny-popover's magical way of finding the target's outermost DOM node relied on this. In lieu of it, ref forwarding is the best way to go.
Feel free to keep using version 3 for the time being, but I recommend migrating to ref forwarding, as this API is far clearer than the mysterious under-the-hood nature of findDOMNode.
from react-tiny-popover.
Thanks for clarification, but I'm still convinced that children should not be a function.
Don't you consider iterating through children and passing ref to each of them, thus delegating the responsibility of using the ref to children instead of hacking a common way of child nodes usage?
from react-tiny-popover.
I may add that functionality alongside the new functionality. Stay tuned.
from react-tiny-popover.
Related Issues (20)
- Wrong children position when containerStyle
- Module `react/jsx-runtime` not found HOT 4
- Could the Popover be controlled by a click event? HOT 2
- Wrong location for left/right positions when some parent has position:absolute HOT 1
- parentElement doesn't work HOT 3
- Question: is this library still maintained? HOT 1
- Reposition doesn't work with the latest version HOT 1
- Problem with rollup: 'syntheticNamedExports: "__moduleExports"' needs an explicit export named "__moduleExports" that does not reexport an unresolved named export of the same module. HOT 1
- Problem: clicking a popover on a popover closes the bottom popover. HOT 12
- Breaking change from 7.0.1 -> 7.1.0 - Nested Popovers and onClickOutside boundary calculation HOT 1
- Popover appears at top left of the screen HOT 3
- Callback for when position changes HOT 1
- positions in decimals causes blurry popover contents HOT 1
- request for onScrollOutside
- Support RTL alignment
- Not work in a shadow root
- DOMRect is not defined HOT 2
- React 18 with Next.js breaks tiny-popover HOT 3
- Best way to have parentElement be the actual parent when rendering a list?
- Popover within <dialog>
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-tiny-popover.