Giter VIP home page Giter VIP logo

Comments (3)

alexkatz avatar alexkatz commented on August 18, 2024

With the release of version 5.0 came some breaking changes, hence the major version bump. React's deprecation of findDOMNode in favor of a more declarative way of tracking refs requires this change moving forward in order for the component to maintain compatibility with React's StrictMode.

Check the docs for helpful examples along with React's ref forwarding API.

Note that findDOMNode has been deprecated in StrictMode. Unfortunately, react-tiny-popover's magical way of finding the target's outermost DOM node relied on this. In lieu of it, ref forwarding is the best way to go.

Feel free to keep using version 3 for the time being, but I recommend migrating to ref forwarding, as this API is far clearer than the mysterious under-the-hood nature of findDOMNode.

from react-tiny-popover.

voroshkov avatar voroshkov commented on August 18, 2024

Thanks for clarification, but I'm still convinced that children should not be a function.
Don't you consider iterating through children and passing ref to each of them, thus delegating the responsibility of using the ref to children instead of hacking a common way of child nodes usage?

from react-tiny-popover.

alexkatz avatar alexkatz commented on August 18, 2024

I may add that functionality alongside the new functionality. Stay tuned.

from react-tiny-popover.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.