alexpiezo / webrtc Goto Github PK

Any kind of help would be appreciated. :)

I am pretty new in the iOS/swift world.

I am writing a very simple iOS app with WebRTC to make a peer connection between server and client. No need an audio or video play, need RTCDataChannel to send the hello message to the server. But when WebRTC queries the STUN server and provides the list of local candidates that does not contain my public IP address. I am doing all of this because there is the NAT in middle of server and client.

The Mac binary is 25 MB. The iOS ones are 1.2 and 1.8 GB each. That doesn't seem right.

Hi,

I'd like to modify a bit of code inside WebRTC itself and build a framework file from it (so that I can use the framework file in my Flutter project).

How do I change the build process to point to my own WebRTC repo?
Ideally, I'd like to use this webrtc codebase: https://github.com/webrtc-sdk/webrtc

Thank you so much!

Is this a dead product now? no update since November last year

Hi,

There is a bug in the performance of H264 in iOS from Pixiv release.
Could you make this repo (M95) support sound for the iOS as Pixiv support?.
I can't use H264 in Pixiv version because a bug in the quality of the H264. this bug has been fixed in latest release of WebRTC from Google.
Thanks

Hi, thanks for your repository. I'm using swift package 94.4606.0 in my project.
This works great in my app with enabled bitcode. It also runs well on a device from xcode.
I am failing building .ipa with the "rebuild from bitcode" checkbox enabled. I am getting this error:

ipatool failed with an exception: #<CmdSpec::NonZeroExitException: $ /Applications/Xcode.app/Contents/Developer/usr/bin/python3
/Applications/Xcode.app/Contents/Developer/usr/bin/bitcode-build-tool -v -t
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin --sdk
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk -o
/var/folders/r3/lvjd6dv93k909d0q32xc51440000gn/T/ipatool20211126-2728-7f6an/thinned-out/armv7/Payload/Service112.app/Frameworks/WebRTC.framework/WebRTC --generate-dsym
/var/folders/r3/lvjd6dv93k909d0q32xc51440000gn/T/ipatool20211126-2728-7f6an/thinned-out/armv7/Payload/Service112.app/Frameworks/WebRTC.framework/WebRTC.dSYM --strip-swift-symbols
/var/folders/r3/lvjd6dv93k909d0q32xc51440000gn/T/ipatool20211126-2728-7f6an/thinned-in/armv7/Payload/Service112.app/Frameworks/WebRTC.framework/WebRTC
Status: pid 8246 exit 1
Stdout:
SDK path: /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.5.sdk

first, I modified the find_sdk.py like this

then I followed your guide, but failed. ```
error: use of undeclared identifier 'FILE_NAME'
NSAssert([key isKindOfClass:[NSString class]],

Why this line is needed in build.sh?

sed -i '' 's/-ffile-compilation-dir/-fdebug-compilation-dir/g' ./build/config/compiler/BUILD.gn

The script builds Debug build for a release. As a result WebRTC crashes sometimes as follows:

Thread 21 name:  signaling_thread 0x0x106e11b00
Thread 21 Crashed:
0   WebRTC                        	       0x105079608 rtc::Thread::ProcessMessages(int) + 132
1   WebRTC                        	       0x1050795ec rtc::Thread::ProcessMessages(int) + 104
2   WebRTC                        	       0x10507ab50 rtc::Thread::PreRun(void*) + 64
3   libsystem_pthread.dylib       	       0x236a2e9ac _pthread_start + 148
4   libsystem_pthread.dylib       	       0x236a2de68 thread_start + 8

because of

void ProcessMessages(StreamReader* stream, SessionData* session) {
...
 default:
         RTC_DCHECK_NOTREACHED(); // <-----------------------------

...
//https://chromium.googlesource.com/external/webrtc/+/master/rtc_base/checks.h

#define RTC_DCHECK_NOTREACHED() RTC_DCHECK(RTC_UNREACHABLE_CODE_HIT)

#define RTC_UNREACHABLE_CODE_HIT false

// The RTC_DCHECK macro is equivalent to RTC_CHECK except that it only generates
// code in debug builds. It does reference the condition parameter in all cases,
// though, so callers won't risk getting warnings about unused variables.
#if RTC_DCHECK_IS_ON
#define RTC_DCHECK(condition) RTC_CHECK(condition)
#endif

// If you for some reson need to know if DCHECKs are on, test the value of
// RTC_DCHECK_IS_ON. (Test its value, not if it's defined; it'll always be
// defined, to either a true or a false value.)
#if !defined(NDEBUG) || defined(DCHECK_ALWAYS_ON)
#define RTC_DCHECK_IS_ON 1
#else
#define RTC_DCHECK_IS_ON 0
#endif

// - RTC_CHECK(x) is an assertion that x is always true, and that if it isn't,
//   it's better to terminate the process than to continue. During development,
//   the reason that it's better to terminate might simply be that the error
//   handling code isn't in place yet; in production, the reason might be that
//   the author of the code truly believes that x will always be true, but that
//   they recognizes that if they are wrong, abrupt and unpleasant process
//   termination is still better than carrying on with the assumption violated.

Hi! Maybe someone knows.. I have a high CPU load during connection between ios ipad app and mac chrome page more than 100% and in the case between ios ipad app and ios safari 60%. What can be done about it?

Could you make WebRTC framework for tvOS? Thank you very much!

Version 93.4577.0

We encountered this issue when copying an iOS app built in Xcode to a device:

https://bugs.swift.org/browse/SR-13366

From the issue description:

Closely associated with SR-13343, cannot install a signed XCFramework containing a Dynamic Library MachO type.  The application builds and fails to launch with a Provisioning Profile error.  

The error is not reproducible when the XCFramework is manually installed and Signed by the App (Embed & Sign setting).

We normally ship the XCFramework with instruction to set the embed setting to Embed and Sign, which as far as I could tell is not a possible configuration through the package manager.

Are the frameworks in this repo signed or unsigned?

Can anyone do a webRTC for watchOS for watchOS 9 when it has CallKit in it

Can you support macos_arm64 ?
Please save me..

the error message shows that the WebRTC.framework file includes the [×86_64, 386] architecture(s), which are not supported by iOS.

Thanks for your repository, your instructions on how to build WebRTC yourself are really helpful, especially when building for macOS!

Did you look into building WebRTC for the Mac Catalyst technology? This would be super helpful to be able to easily create Mac versions of iPad apps which use WebRTC, for example the Jitsi Meet iOS app. I found some hints on how to build for Catalyst here. Unfortunately it requires a lot of modifications, as the Catalyst API doesn't support OpenGL ES, and needs to suppress some deprecation errors. My build fails at SOLINK obj/sdk/x64/WebRTC obj/sdk/x64/WebRTC.TOC with libvpx_asm, with only 9 steps missing...

Getting this issue while try to run on mac

Please update the library to the current version of GoogleWebRTC (1.1.31999).
Can you enable bitcode support?