Comments (17)
did you played rhe video (and kept it playing in the background) when running the issue-report ?
@AlexPresso yes, but it just keeps loading, showing the loading spinner.
Are these videos playing without the patch ?
Here's the result with and without the patch:
Container | Video codec | Audio codec | Plays with patch? | Plays without patch? |
---|---|---|---|---|
mp4 | hevc | aac_lc | ❌ | ✅ |
matroska,webm | h264 | eac3 | ❌ | ❌ |
mp4 | h264 | aac_lc | ✅ | ✅ |
As for checking the patch_utils.sh
script, here you go:
root@:~# ls -al /var/packages/VideoStation/patch
total 16
drwxr-xr-x 2 root root 4096 Dec 10 08:53 .
drwxr-xr-x 6 root root 4096 Dec 10 08:55 ..
-rw-r--r-- 1 root root 62 Dec 10 08:53 patch_config.sh
-rw-r--r-- 1 root root 1497 Dec 10 08:53 patch_utils.sh
root@:~# ls -al /var/packages/CodecPack/patch
total 16
drwxr-xr-x 2 root root 4096 Dec 10 08:53 .
drwxr-xr-x 5 root root 4096 Dec 10 08:54 ..
-rw-r--r-- 1 root root 62 Dec 10 08:53 patch_config.sh
-rw-r--r-- 1 root root 1497 Dec 10 08:53 patch_utils.sh
Thank you for your time and help with this 🙇
from videostation-ffmpeg-patcher.
Thank you for testing, that's great news we're making progress and I know how to fix it, I'll make some change in the patcher to give right permissions to the scripts, I'll get back to you when everything ready :)
from videostation-ffmpeg-patcher.
Hi @pedroms
I don't see any issue or sign that ffmpeg was running from the issue-report, did you played rhe video (and kept it playing in the background) when running the issue-report ?
Are these videos playing without the patch ?
from videostation-ffmpeg-patcher.
I just seen that the patch_utils.sh
script was not loaded by the ffmpeg wrapper, it's required to run:
FFMPEG prev logs...................................
Cannot load patch_utils.sh
Could you please give me the output of the following commands:
ls -al /var/packages/VideoStation/patch
ls -al /var/packages/CodecPack/patch
from videostation-ffmpeg-patcher.
Hi @pedroms, thanks to you for the feedback :) .
I don't have this issue using DSM 7.0+ but it could be a permission issue on DMS 6.2, could you please try to run the following commands to change the permissions of the patch files in VideoStation and CodecPack:
VideoStation
chown -R root:VideoStation /var/packages/VideoStation/patch
chmod -R 755 /var/packages/VideoStation/patch
CodecPack:
chmod -R 755 /var/packages/CodecPack/patch
After changing the permissions, please try to play a video file again and after waiting maximum 1 min, if nothing plays, please run the issue-report
tool again and copy paste the output; so we can check if something changed or not :)
from videostation-ffmpeg-patcher.
@AlexPresso after updating the permissions with those commands, this is the result:
root@:~# ls -al /var/packages/VideoStation/patch
total 16
drwxr-xr-x 2 root VideoStation 4096 Dec 15 09:35 .
drwxr-xr-x 6 root root 4096 Dec 15 09:45 ..
-rwxr-xr-x 1 root VideoStation 62 Dec 15 09:35 patch_config.sh
-rwxr-xr-x 1 root VideoStation 1497 Dec 15 09:35 patch_utils.sh
root@:~# ls -al /var/packages/CodecPack/patch
total 16
drwxr-xr-x 2 root root 4096 Dec 15 09:35 .
drwxr-xr-x 5 root root 4096 Dec 15 09:36 ..
-rwxr-xr-x 1 root root 62 Dec 15 09:35 patch_config.sh
-rwxr-xr-x 1 root root 1497 Dec 15 09:35 patch_utils.sh
I tried playing the video again (mp4, hevc, aac_lc) and it did not work 🙁 Here's the report: https://gist.github.com/pedroms/59173b5eb2eb10da2b14d2a58517e2d5
from videostation-ffmpeg-patcher.
@pedroms if you run the following command in your terminal, do you have any error ? source /var/packages/VideoStation/patch/patch_utils.sh
?
from videostation-ffmpeg-patcher.
@AlexPresso no error, it does not return anything:
root@:~# source /var/packages/VideoStation/patch/patch_utils.sh
root@:~#
from videostation-ffmpeg-patcher.
Hi @pedroms
Thank you for the tests, I added some error logging in the following PR (#116) it's not a fix for your issue yet, just a step for me to try get more informations about your issue, would it be possible for you to try it please:
- uninstall the patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/more_error_logging/patcher.sh | bash -s -- -a unpatch
- install the error logging patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/more_error_logging/patcher.sh | bash -s -- -a patch -b more_error_logging
Please try to run another video file and run the issue-report
script again, hopefully we can get the error thrown when the script is trying to load patch_utils.sh
from videostation-ffmpeg-patcher.
@AlexPresso followed your instructions. Here's the latest issue report: https://gist.github.com/pedroms/01f2e056d9557abdc7e26bc091c284d8
from videostation-ffmpeg-patcher.
Could you just do this one last try before I make changes to the patcher please:
chmod -R 755 /var/packages/CodecPack/target/pack/bin
And try to play a video file as is
from videostation-ffmpeg-patcher.
I pushed a new test wrapper in #116
You can try it out using the following:
- uninstall the patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/more_error_logging/patcher.sh | bash -s -- -a unpatch
- install the test patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/more_error_logging/patcher.sh | bash -s -- -a patch -b more_error_logging
I'm not facing the same issue on DSM 7.0+, so it's possible the setuid
on the CodecPack's scripts is messing with DSM 6.2 apparmor configuration, let's try :)
from videostation-ffmpeg-patcher.
@AlexPresso thank you for your work to fix this. I followed your latest instructions and, even with the new test patch, the video fails to play 😕 Similar to the previous times, I ran the report tool while the video is trying to play: https://gist.github.com/pedroms/b5c18c64d22c0300a085fabebe4f66ce
from videostation-ffmpeg-patcher.
Okay, I'll remove these utils script and put everything back in the ffmpeg
wrapper directly, so the script won't need to load any external file again
Sorry, it took long time but I wanted to test everything before choosing this solution
from videostation-ffmpeg-patcher.
Hi @pedroms
I pushed a new test wrapper in #117
You can try it out using the following:
- uninstall the old patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/main/patcher.sh | bash -s -- -a unpatch
- install the test patch :
curl https://raw.githubusercontent.com/AlexPresso/VideoStation-FFMPEG-Patcher/rem_extern_scripts/patcher.sh | bash -s -- -a patch -b rem_extern_scripts
There are no more external scripts to load so there should not be any permission issue anymore
from videostation-ffmpeg-patcher.
@AlexPresso 🎉 it's all fixed now! Here's the result with the test patch:
Container | Video codec | Audio codec | Plays? |
---|---|---|---|
mp4 | hevc | aac_lc | ✅ |
matroska,webm | h264 | eac3 | ✅ |
mp4 | h264 | aac_lc | ✅ |
Thank you so much for your help and for keeping this patcher alive and well. Happy holidays!
from videostation-ffmpeg-patcher.
You're welcome, thanks to you for testing and for your patience :)
Happy Holidays ! 🎅
from videostation-ffmpeg-patcher.
Related Issues (20)
- [BUG] cant install v2.5 HOT 4
- [BUG] offline trancoding fail After 2.5 HOT 6
- [BUG] can't update with 2.6 from 2.0 HOT 11
- Can't create any thumbnail of new video. HOT 3
- Unsupported format HOT 2
- Successfully patched. But DTS videos not playing through Video Center in browser. HOT 10
- [QA] Download motd.txt error HOT 5
- [BUG] failure writing output to destination HOT 3
- [QA] Error on patching ffmpeg HOT 5
- [QA] DS Video and ffmpeg HOT 2
- [BUG] No sound on at least two movies HOT 16
- [QA] Restore AAC Support for Audio Station HOT 1
- [QA] Could the process of installing/uninstalling this patcher break Synology Application Service? HOT 3
- [BUG] Specific video will not play HOT 5
- wrong aspect ratio in dsvideo HOT 5
- I still can't play dts when I use 920 + update6 42962.video station version is 3.0.7-2512 .I've already tried ffmpeg4 5 6.Play or spin in circles
- [QA] Version 2.0 or 2.3 HOT 1
- [BUG] Stop playing some formats that played before patching HOT 26
- [QA] Play m3u8 playlist working from app but not from browser HOT 15
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from videostation-ffmpeg-patcher.