alexshikov / bitrise-step-appcenter-dsym-upload Goto Github PK

I am using this step in our Xamarin.iOS workflow and it appears that the step is not properly escaping spaces in the dSym file path. Output from one of our builds:

+------------------------------------------------------------------------------+

| (10) [email protected] |
+------------------------------------------------------------------------------+
| id: appcenter-dsym-upload |
| version: 0.1.2 |
| collection: https://github.com/bitrise-io/bitrise-steplib.git |
| toolkit: bash |
| time: 2018-02-16T15:28:38-08:00 |
+------------------------------------------------------------------------------+
| |
INFO[15:28:38] * [OK] Step dependency (node) installed, available.

• hash appcenter
• echo 'Microsoft AppCenter CLI is not installed. Installing...'
  Microsoft AppCenter CLI is not installed. Installing...
• npm install -g appcenter-cli
  /usr/local/bin/appcenter -> /usr/local/lib/node_modules/appcenter-cli/bin/appcenter.js
• [email protected]
  added 228 packages in 10.502s
• envman add --key BITRISE_DSYM_PATH
• appcenter crashes upload-symbols -s /Users/vagrant/deploy/iSurvey.iOS 2-16-18 3.23 PM.dSYM.zip -a {account/app} --token {token} --quiet
  Error: Command 'crashes upload-symbols -s /Users/vagrant/deploy/iSurvey.iOS 2-16-18 3.23 PM.dSYM.zip -a {account/app} --token {token} --quiet' failed with exception "Unknown arguments: 2-16-18 3.23 PM.dSYM.zip"
  | |
  +---+---------------------------------------------------------------+----------+
  | x | [email protected] (exit code: 3) | 17 sec |
  +---+---------------------------------------------------------------+----------+
  | Issue tracker: ...b.com/alexshikov/bitrise-step-appcenter-dsym-upload/issues |
  | Source: https://github.com/alexshikov/bitrise-step-appcenter-dsym-upload |
  +---+---------------------------------------------------------------+----------+

Hi, I'm currently using your integration with Bitrise, but I am receiving the following error with the system tries to upload the dSYM zip file. Any ideas why this is happening?

+------------------------------------------------------------------------------+

| (8) appcenter-dsym-upload@0                                                  |
+------------------------------------------------------------------------------+
| id: appcenter-dsym-upload                                                    |
| version: 0.1.3                                                               |
| collection: https://github.com/bitrise-io/bitrise-steplib.git                |
| toolkit: bash                                                                |
| time: 2022-02-02T19:15:43Z                                                   |
+------------------------------------------------------------------------------+
|                                                                              |
INFO[19:15:43]  * [OK] Step dependency (node) installed, available. 
+ hash appcenter
+ echo 'Microsoft AppCenter CLI already installed.'
Microsoft AppCenter CLI already installed.
+ envman add --key BITRISE_DSYM_PATH
+ appcenter crashes upload-symbols -s '/Users/vagrant/deploy/Lab Central.dSYM.zip' -a ProofDx/LabCentral-iOS-Beta --token BITRISE_APPCENTER_BETA_API_TOKEN --quiet
Error: failed to start the symbol uploading
|                                                                              |
+---+---------------------------------------------------------------+----------+
| x | appcenter-dsym-upload@0 (exit code: 3)                        | 6.35 sec |
+---+---------------------------------------------------------------+----------+
| Issue tracker: ...b.com/alexshikov/bitrise-step-appcenter-dsym-upload/issues |
| Source: https://github.com/alexshikov/bitrise-step-appcenter-dsym-upload     |

I had an issue where reading the $BITRISE_DSYM_PATH environment variable after this step ran in my workflow it returned an empty string. I noticed the following line envman add --key BITRISE_DSYM_PATH. It seems like that overwrites the value, no? Is this somehow intentional?

I'd be happy to create a PR, but first wanted to check I'm not going crazy and might be misunderstanding something, somehow hah.

+ hash appcenter
+ echo 'Microsoft AppCenter CLI is not installed. Installing...'
Microsoft AppCenter CLI is not installed. Installing...
+ npm install -g appcenter-cli
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3[REDACTED]42
/usr/local/bin/appcenter -> /usr/local/lib/node_modules/appcenter-cli/bin/appcenter.js
> fast-xml-parser@3.[REDACTED]6.0 postinstall /usr/local/lib/node_modules/appcenter-cli/node_modules/fast-xml-parser
> node tasks/postinstall.js || exit 0
EDACTED]mLove fast-xml-parser? Check https://amitkumargupta.work EDACTED]mfor more projects and contribution.
npm WARN [email protected].[REDACTED] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself.
+ [email protected]
added 476 packages from 430 contributors in [REDACTED]6.668s
+ envman add --key BITRISE_DSYM_PATH
+ appcenter crashes upload-symbols -s /Users/[REDACTED].dSYM.zip -a [REDACTED]/[REDACTED] --token [REDACTED] --quiet
Error: failed to start the symbol uploading

I'm getting this output.

Could npm WARN [email protected].[REDACTED] requires a peer of [email protected] but none is installed. You must install peer dependencies yourself. be the error?

Or is the problem, that I my username/appname is wrong?

Dear @alexshikov!

As you might have heard, HockeyApp is being retired. Bitrise, of course, has officially maintained HockeyApp Steps until now. These Steps are now going to be deprecated. We’ve decided instead to create AppCenter Steps to support the new 3rd party platform, and these Steps will be officially maintained, too.
I opened this ticket to let you know about this because you have a Step created for our community. We’d be really happy if you continued contributing to the new Step after the change!

Tamas @ Bitrise