Giter VIP home page Giter VIP logo

nordic.nvim's Introduction

 

  • Some of the things I enjoy and use(d) ⬆️.
  • Trying to write software that prevents the collapse of civilization. Fast computers lead to lazy programmers.
  • Electrical & Electronic Engineer by education, Software Engineer by heart.
  • Recently completed my Master's in radar engineering and machine learning.
  • Currently working as a Software and ML/MLOps engineer.
  • 💍 (Was) Most likely the only married Arch Linux user. Now a NixOS enjoyer.

 

🔭 Interests

 

  • The Linux Kernel: The work done here is obviously exceptional - I would love to contribute one day.
  • Game Engines: I have written a graphics engine from scratch and the technology is fascinating (and complex!). Hopefully I can work on something like this again.
  • Radars: Obviously, I did my Master's thesis in this topic!

 

📈 Some Statistics

 



"You can't know everything, but you should convince yourself that you can know anything." - John Carmack

"That’s the way that we're trending, everybody’s on Slack all day and very few people are doing real work." - Jonathan Blow

nordic.nvim's People

Contributors

3n3l avatar 5-pebbles avatar alexvzyl avatar filahf avatar github-actions[bot] avatar jemag avatar jonaspleyer avatar juniorsundar avatar kuntau avatar lcrownover avatar leaysgur avatar lostl1ght avatar luxus avatar mactep avatar ntbbloodbath avatar thelasteinherjar avatar vibhav201 avatar xxiaoa avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

nordic.nvim's Issues

CI: Cannot push to protected branch

We push our formatting and docs changes to the main branch, but it is not protected and we cannot push directly. Should fix this at some time.

Apparently the suggested way is to open a new PR and automatically merge it in with the changes.

Allow disabling italics in comments

Hey, hope you're doing well!

I'm really loving this colorscheme, I'm not really a Nord fan but this variant looks really cool, nice job!

The only thing I would like is to be able to disable the italics in some hl groups like Comment from the setup function so that I don't have to add extra code in my setup to gui=NONE that hl group, would it be possible? :p

Cheers

Missing vim.g.colors_name

I think you should probably add a vim.g.colors_name in your colorscheme

Expected:

:lua print(vim.g.colors_name)
nordic

Current:

:lua print(vim.g.colors_name)
nil

Other color schemes do this as well
Example:

:lua print(vim.g.colors_name)
catppuccin

[ENH] transparent background for popups (telescope, mason...)

Congrats for the theme, colors are awesome and the setup straightforward (I am mostly using gruvbox-material, which is vimscript so a little less straightforward to use). However, I was expecting that the transparency option would make popup windows bg transparent as well. I am no colorscheme expert, but I'd be glad to help!

Multiplatform Support

Love how the theme is coming along!

Are there any plans to bring the theme to other editors?

Telescope classic theme is not activated

Hey man, loved your theme. My current favorite theme of nord palette.
I tried to get the classic theme for telescope popup but the theme seems to be in flat.
Do you have any suggestion regarding this ?

TS Context poor colors

Hello

The treesitter context is making the line literally impossible to read, also when i go in insert mode, it anyway stays the same.

Screenshot from 2023-07-29 22-36-09

Screenshot from 2023-07-29 22-37-21

Is there a way to disable it?


Or make something like an underline like this, without changing anything but underline ?

Screenshot from 2023-07-29 22-44-50

Low legibility for code in help

Nordic use same color as comment for code in help make them very hard to read. Majority of other theme use string color. See screenshot

Nordic

Screen Shot 2023-02-05 at 23 36 42

Tokyonight

Screen Shot 2023-02-05 at 23 37 05

swap_backgrounds not working

I'm using lazy.nvim. I found out that swap_background option is not working. I tried to swap them with on_palette option and figured out that it is called twice and therefore not working. I believe it is a cause why swap_backgrounds is broken.

    {
      'AlexvZyl/nordic.nvim',
      event = 'VeryLazy',
      config = function()
        local counter = 0
        require('nordic').setup({
          on_palette = function(palette)
            counter = counter + 1
            print(counter, palette.gray0, palette.black1)
            local gray0 = palette.gray0
            palette.gray0 = palette.black1
            palette.black1 = gray0
            return palette
          end,
          -- swap_backgrounds = true,
        })
        vim.cmd('colorscheme nordic')
      end,
    },

Change NeoTreeGitAdded

Hi, thanks for great color scheme!

I'm trying to change NeoTreeGitAdded.

local palette = require 'nordic.colors'

require 'nordic'.setup({
  cursorline = {
    theme = 'light'
  },
  override = {
    NeoTreeGitModified = {
      fg = palette.orange.base, -- works perfect
    },
    NeoTreeGitAdded = {
      fg = palette.orange.base, -- not working
    },
  },
  on_palette = function(nordicPalette)
    nordicPalette.git.add = '#FFFFFF' -- not working
    return nordicPalette
  end,
})

vim.cmd("colorscheme nordic")

How I can to change color?

It's looks like this:

Снимок экрана 2023-11-14 в 09 00 34

Onedark nordic, visual highlight difficult to see

When highlighting in visual mode the background of what is being highlighted is impossible to see. In the screenshot the ASCI art is highlighted in visual mode its almost impossible to distinguish from the background. Could the highlighting color be changed? If so, what is the procedure to do so?
Screenshot 2023-03-24 at 1 48 13 PM

Refactor to make code less confusing

I will edit this and add items to the list as I run into them

Here is a list of things I would like to do:

  1. all colors have separate values in the palette we don't change these just make new ones.

  2. all configuration happens in extend_palette that way its safe to use colors in the default configuration.

  3. All configuration options are reversible so if I load it with one config and then another there will be no issues. this builds on point 1.

Colors: Redo the dark colors/blacks

Currently one black color was chosen (quickly generated using a random tool) and the others generated by blending existing colors. I would prefer that these colors are more carefully chosen.

Issue with telescope integration

vim --version

NVIM v0.8.2
Build type: Release
LuaJIT 2.1.0-beta3
Compiled by [email protected]

Minimal init.lua

-- Install packer
local install_path = vim.fn.stdpath 'data' .. '/site/pack/packer/start/packer.nvim'

if vim.fn.empty(vim.fn.glob(install_path)) > 0 then
	vim.fn.execute('!git clone https://github.com/wbthomason/packer.nvim ' .. install_path)
end

local packer_group = vim.api.nvim_create_augroup('Packer', { clear = true })
vim.api.nvim_create_autocmd('BufWritePost',
	{ command = 'source <afile> | PackerCompile', group = packer_group, pattern = 'init.lua' })
require('packer').startup(function(use)
	use 'wbthomason/packer.nvim'
	

	use {'AlexvZyl/nordic.nvim',config=function ()
		-- available (flat/classic)
		require 'nordic' .setup {
			telescope = {
				-- Available styles: `classic`, `flat`.
				style = 'flat'
			}
		}
	end}


end)
vim.cmd[[colorscheme nordic]]

Error :

Error detected while processing /Users/adi/.config/nvim/init.lua:
E5113: Error while calling lua chunk: /Users/adi/.config/nvim/init.lua:21: /Users/adi/.config/nvim/init.lua..nvim_exec() called at /Users/adi/.config/nvim/init.lua:0../Users/adi/.local/share/n
vim/site/pack/packer/start/nordic.nvim/colors/nordic.vim, line 1: Vim(lua):E5108: Error executing lua ...nordic.nvim/lua/nordic/groups/integrations/telescope.lua:83: attempt to index field 'te
lescope' (a nil value)
stack traceback:
        ...nordic.nvim/lua/nordic/groups/integrations/telescope.lua:83: in main chunk
        [C]: in function 'require'
        ...pack/packer/start/nordic.nvim/lua/nordic/groups/init.lua:32: in function 'get_groups'
        ...m/site/pack/packer/start/nordic.nvim/lua/nordic/init.lua:20: in function 'load'
        [string ":lua"]:1: in main chunk
        [C]: in function 'cmd'
        /Users/adi/.config/nvim/init.lua:21: in main chunk
stack traceback:
        [C]: in function 'cmd'
        /Users/adi/.config/nvim/init.lua:21: in main chunk

Haven't really had time to look at what might be causing this . But it looks like telescope settings doesn't extend to the opts table.
I will look into this tonight.

Request TreeSitter support

Hey, hope you are doing well.
As you know, I love your color scheme and have been using it for over 2 months now. I switched to LunarVim recently due to lsp config for tex and cpp ( i couldnt get it done even after seeing a lot of tutorials and dotfiles(including yours :p)). I want to use your colorscheme there as well. However, its only possible if your scheme is TreeSitter supported and listed here
https://github.com/rockerBOO/awesome-neovim#colorscheme
It is strange cause I see a nice color with tree sitter, but it breaks when I add yours theme in lunar vim. Can you look into this ?

Alacritty terminal theme support

First off, beautiful theme! I'm coming from using Gruvebox & wanting to change it for a while, this gives a great fresh vibe & similar soothing color pallets 🌈

I use Alacritty as my terminal & ended up porting the theme using 🤖 chatgpt by inputting iterm2 nordic theme

This is what it gave me & with minor tweaks to selection colors, it looks pretty decent.

colors:
  # Default colors
  primary:
    background: '#242626'
    foreground: '#BBBDAF'

  # Normal colors
  normal:
    black: '#191C1D'
    red: '#BD6062'
    green: '#A3D6A9'
    yellow: '#F0DFAF'
    blue: '#8FB4D8'
    magenta: '#C7A9D9'
    cyan: '#B6D7A8'
    white: '#BDC5BD'

  # Bright colors
  bright:
    black: '#727C7C'
    red: '#D18FAF'
    green: '#B7CEB0'
    yellow: '#BCBCBC'
    blue: '#E0CF9F'
    magenta: '#C7A9D9'
    cyan: '#BBDA97'
    white: '#BDC5BD'


  # Selection color
  selection:
    text: '#000000'
    background: '#F0DFAF'

I'll wait for an "official" port to arrive, but meanwhile, others can use this as an alternative.

The official port whenever comes, can also be optionally added to: https://github.com/alacritty/alacritty-theme

Cursorline option to set visual selection color

I cant find an option to set the color to be used for visual selections.


Is the a way to set the color for visual selection, I can change the highlight group, but it would be nice to still be able to use the cursorline settings.

I think it would be better to have a option to set the bg color in cursorline which would then be used in the blend.
Instead of having a theme option.

If there is not something like that implemented and you are interested, I could make a pr for it?

Visual selection regression: not enough contrast between selected / non-selected background

I just pulled the latest a couple of days ago, and it looks like the visual selection background color has been updated to darken the background, whereas it used to lighten the background.

I feel like there's no longer enough contrast to see the difference between selected / non-selected text.

This also causes problems when I'm sharing my screen for zoom calls, because the video compression reduces the contrast even further so no one can tell what I have selected.

Screenshot of how it looks now:

Screenshot 2023-07-08 at 3 40 51 PM

Feat: Reduce startup time

Currently, the plugin loads all the colors for all the integrations. This is not strictly necessary, and it would be cool to allow the user to explicitly load specific plugins. Some people love to reduce their startup times...

Error while loading plugin

E5108: Error executing lua ...nordic.nvim/lua/nordic/groups/integrations/telescope.lua:83: attempt to index field 'telescope'
(a nil value)

I do have config block (copy-pasted from readme)

	use({
		"AlexvZyl/nordic.nvim",
		config = function()
			require("nordic").setup({
				telescope = {
					style = "flat",
				},
			})
		end,
	})

Suggestion: don't set LeapBackdrop in default

I think user should opt-in to use this old style like the lightspeed. Personally it break my flow with it enabled.

And I think the previous yellow #D9B263 is better than this new red.

Implementation Guide

Using Aurora colors in Nord for more contrast looks like a great idea, by your screenshots!

I would appreciate if you drafted a generalized color palette/list of colors, which I and other people could use to develop themes for other applications like VSCode or terminals.

make visual selection easy to see

currenty visual selection is really hard to distinguish from general background. would be good to have it be a lighter color, so it contrasts with the backround more:

Screenshot 2023-04-09 at 17 54 52

i'm sure one can configure it but I'm opening this issue in the name of having defaults be as good as they possibly can. thanks in advance.

Add visual preview of the colour palette

Hey, thank you for this amazing theme. I just wish it had many official ports (like Catppuccin and Dracula), maybe in the future.

For now, I think there should be a colour palette preview available to view in the README.md for easy acces to the palette. This might also help others in making ports.

So, I made one :)

Nordic

Nordic theme for helix editor

Hello, thank you for such great theme!
I used it in vim, but now I switched to helix editor and I would love to use nordic there too.
Do you have plans for migrating theme for helix?

No selection highlight when transparent mode is enabled

Hi, i am using this theme almost half a year and everything was fine, but a couple weeks ago, after updating plugins - this strange bug appeared. I cannot find any similar issues (but there is a chance, that i'm just blind :) ), so have to create one.

Problem definition
There is no text highlight below selection in visual mode (no matter which mode is it: regular/line/block). Such behaviour appears only if the transparent_bg is set to true, otherwise everything works as it should be.

PoC
image

Environment details

  • OS: EndeavourOS Linux / MacOS 14 Sonoma
  • Terminals: alacritty / wezTerm
  • nvim 0.9.5
  • plugin manager: Lazy (latest stable)
  • nordic.nvim (tested on both main and dev branches)

Nordic setup is pretty much same as default, just added few mods.

    {
        'AlexvZyl/nordic.nvim',
        branch = "dev",
        lazy = false,
        priority = 1000,
        config = function()
            require 'nordic' .setup {
                -- This callback can be used to override the colors used in the palette.
                on_palette = function(palette) return palette end,
                -- Enable bold keywords.
                bold_keywords = false,
                -- Enable italic comments.
                italic_comments = true,
                -- Enable general editor background transparency.
                transparent_bg = true,
                -- Enable brighter float border.
                bright_border = false,
                -- Reduce the overall amount of blue in the theme (diverges from base Nord).
                reduced_blue = true,
                -- Swap the dark background with the normal one.
                swap_backgrounds = true,
                -- Override the styling of any highlight group.
                override = {
                    LineNr = {
                        -- fg = "#b07c05",
                        fg = "#60728A",
                        bold = true,
                    },
                },
                -- Cursorline options.  Also includes visual/selection.
                cursorline = {
                    -- Bold font in cursorline.
                    bold = false,
                    -- Bold cursorline number.
                    bold_number = true,
                    -- Avialable styles: 'dark', 'light'.
                    theme = 'dark',
                    -- Blending the cursorline bg with the buffer bg.
                    blend = 0.7,
                },
                noice = {
                    -- Available styles: `classic`, `flat`.
                    style = 'classic',
                },
                telescope = {
                    -- Available styles: `classic`, `flat`.
                    style = 'classic',
                },
                leap = {
                    -- Dims the backdrop when using leap.
                    dim_backdrop = false,
                },
                ts_context = {
                    -- Enables dark background for treesitter-context window
                    dark_background = true,
                }
            }
            vim.cmd.colorscheme 'nordic'
        end
    },

Related notes to which I would like to draw attention
On previous installed version (unfortunately I can't remember which one), even with enabled transparent background, floating windows (such as Lazy or Mason) kept their non-transparent bg, which in my opinion, was much more convenient than now. Perhaps it would be worth (if it is possible) making a separate switch to leave opaque color for them or at least change it?
image

P.S. Also want to thank you for creating and maintaining this marvelous theme!

Use palette in default values.

I would like to make it so you can use the palette for default values.

The rest of this issue assumes you are okay with that...

To avoid a circular import, I would need to move all option related values to a function… extend_palette makes the most sense, they will all be in the same place to which I like.

The only part that's not straight forward is the reduced blue option.
I don't like how it works currently, (you can't change it back once it's set to reduced).

To fix that, I would need to save a reduced and normal option, I can't think of a clean way of doing that.


My best idea so far:

extend_colors could take the options as an argument, and it could then be call in config, there by setting the defaults.

I could then have something like palette.white_normal and palette.white_reduced_blue in colors/nordic.

However palette.white0 would not have a value until config is run (seems like a bad idea), unless I added something like palette.white0 = palette.white_normal which is setting two defaults (also feels like a bad idea).


Does anyone have any ideas or does that work?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.