Giter VIP home page Giter VIP logo

laravel-firebase's People

Contributors

alfa6661 avatar dblazeski avatar kikemarto avatar pinguinjkeke avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

laravel-firebase's Issues

Bug in send to multiple device tokens

Steps to recreate:

  • implement routeNotificationForFirebase in your model
  • when the model returns 2 device tokens then you will find this error

Expected result:

  • each of the 2 devices will return 1 notification each

Actual result:

  • the 1st device receives 1 notification
  • the 2nd device receives 2 notification

I have tried to fix this and found the error is the addRecipent in the for loop in the send() method of FirebaseChannel. I solved the problem by changing it to:

public function send($notifiable, Notification $notification)
    {
        $devices = $notifiable->routeNotificationFor('firebase');
        if (empty($devices)) {
            return;
        }

        $firebase = $notification->toFirebase($notifiable);

        foreach ($devices as $device) {
            $this->message->addRecipient(new Device($device));
        }
        $this->message->setNotification($firebase->notification)->setData($firebase->data);

        try {
            $response = $this->client->send($this->message);
        } catch (Exception $e) {

        }
    }

Accumulates senders when messages are deferred

class Alfa6661\Firebase\FirebaseChannel method send

try {
            foreach ($devices as $device) {
                $this->message->addRecipient(new Device($device))//<New senders are added every time you send
                    ->setNotification($firebase->notification)
                    ->setData($firebase->data);

                $response = $this->client->send($this->message);
            }
        } catch (Exception $ex) {
        }

As a result, everyone sees the messages of all.

This is the case if messages are sent through the queue

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.