alimir1 / eureka-striperow Goto Github PK

Hi, I'm writing on behalf of Xmartlabs.

We have done a review of the source code and found some minor issues, we would like you to consider fixing issues listed below before including this new row in Eureka Community.

1. The row do nat have an associated value to access read data. Actually, to access credit card data and validate it, it must be done through Stripe´s textfield. In the example you are storing this value as an instance variable when you create the row. We suggest defining a new type, CreditCard, to store credit card information: number, ccv, expiration date) and then using this type as the row / cell type.

2. You are referencing stripe´s textfield to validate if credit card data is valid. We suggest creating a new rule for this case.

3. It is not actually uploaded to Cocoapods, we suggest uploading it.

Looking forward to include it in our Eureka community. We really appreciate contributions,
Thank you!