Group deletes about fabric-history HOT 6 CLOSED

Hey this is working great now! thanks very much for looking into this. I think my problem was cached modules. after removing them and reinstalling it all worked fine.

from fabric-history.

Hi,

Thank you ! Each operation is a history point. Your code will trigger the history event separately. Therefore, the undo operation is working separately. FabricJS doesn't have 'removeAll' function for your expectation. Maybe we can do a trick about this one but I have to do some research.

from fabric-history.

I think i understand. Would you expect the undo to have to be peformed twice for a case where two objects where deleted in one delete?

from fabric-history.

Yes, because you are looping through them. I will try to implement history toggle for such kind of needs. And, it would fit for this situation.

from fabric-history.

Hello again,

I have implemented the on/off history functions in 1.6.0. You may use like this,

function removeActiveObject() {
    const activeObjects = canvas.getActiveObjects();

    // remove objects
    if (activeObjects.length > 0) {
        canvas.offHistory();

        for (var i = 0; i < activeObjects.length; i++) {
            if (!activeObjects[i].isEditing) {
                canvas.remove(activeObjects[i]);
            }
        }

        canvas.onHistory();
    }
}

I think this is what you need !

from fabric-history.

Hi sorry for the late reply. Thanks for looking into this! I think im not following is the onHistory / offHistory an implementation of fabricjs or fabric-history as im getting an error for undefined.

from fabric-history.