allaboutapps / toolbox Goto Github PK

Implementing UIAdaptivePresentationControllerDelegate for custom Coordinator is cumbersome.

Especially using these functions is not supported:

• presentationControllerDidAttemptToDismiss
• presentationControllerShouldDismiss

should use PHPickerViewController for iOS 14

Originally posted by @mbuchetics in #1 (comment)

It would be cool if the coordinator would automatically support defined DeepLinking routes that could be called from the AppDelegate or anywhere in the app (e.g. when clicking on a notification).

The DeepLinks should be defined by the app, but only passed to the coordinator. The coordinator also has to take loading states into consideration, so it has to support blocking.

See here for an example:
Link

this swift package has no license file in its root directory, causing LicensePlist to throw an error

[Assert] Setting modalPresentationStyle once presentationController has been accessed will have no effect until <UINavigationController: 0x7f918a064a00> is presented, dismissed, and presented again.

`public init(rootViewController: UIViewController = UIViewController()) {
self.rootViewController = rootViewController

    super.init()
    
    if rootViewController.presentationController?.delegate == nil {
        rootViewController.presentationController?.delegate = self
    }
}`

It would be great if a setViewControllers function for the NavigationCoordinator would be added to the Toolbox .

• Rename inset parameter for layout helper function to appropriate name.
• Move convenience init from UIEdgeInset to NSDirectionalEdgeInset

Add helper for creating layout constraints.