allalgorithms / python Goto Github PK

• add new cryptography
• rename /greedy-algorithms to /greedy

Hi, everyone!

Do you know any algorithm implementation in any language, that you wanna share with us?

Open a pull request in any of the programming languages available, or in Python this case

Hi, everyone!

Do you know any algorithm implementation in any language, that you wanna share with us?

Open a pull request in any of the programming languages available, or in Python this case

#11 Done, pls add Hacktoberfest love 🎃

Hi! I am creating an issue because even though the project seems quite interesting, the code quality (from what I saw) is at best okay-ish, at worst simply bad, be it from only PEP8 weirdness, or non-pythonicness alone.
Though I do not mean to be disrespectful to all the contributors, it seems that the lack of code review is a cause of overall poor code quality on this repo.

I would love to help review code and contribute on my free time, but improving the current code is a daunting task that I cannot undertake alone.
I also know that reviewing code alone is really tedious, and that it would slow the contribution rate, and I understand if you don't want to integrate review in the workflow.

Sincerely,
Amaras

I am creating an issue because...This is Total Error

According to #32 (comment)

Hi @Zxey I liked, but it seems that the algorithm isn't properly implemented.

According to this the following gif:

From 1-100 the lucky numbers should be:

1, 3, 7, 9, 13, 15, 21, 25, 31, 33, 37, 43, 49, 51, 63, 67, 69, 73, 75, 79, 87, 93, 99

This is the link to your implementation repl.it/@abranhe/lucky-numbers-in-python online, I just set the range from 1 - 100.

In a part of the output you will see:

number 17 is not lucky
number 18 is not lucky
number 19 is lucky
number 20 is not lucky
number 21 is not lucky
number 22 is not lucky
number 23 is not lucky
number 24 is not lucky
number 25 is not lucky
number 26 is not lucky
number 27 is lucky
number 28 is not lucky

Where they don't match with the output it should be:

Eg:

• 19 isn't lucky
• 25 is lucky
• 27 isn't lucky
• and so on ...

So this need to be fixed to be merged, I am creating an issue right now, hopefuly we will implement correctly.

We need to find the a correct implementation for Lucky Numbers