alliance-pcsg / primo-explore-external-search Goto Github PK

When I add "&testAngularCompatibility=true" to our discovery url to test compatibility with Angular 1.8 I get the following console error:

Uncaught TypeError: can't access property "facetService", xx.prmFacetCtrl is undefined

I was wondering if you have encountered this issue and if so, have you implemented a fix for this? Thank you for your time.

useful resource: http://www.oclc.org/support/help/searchingworldcatindexes/Default.htm#06_Format_Document_Type_Codes/Format_Document_type_codes.htm#worldshare_wc_discovery_formats

• add dependencies
• write tests
• add travis
• add info to README

clicking "load more results" makes the facet vanish. 😢

It looks like the Worldcat icon is 404ing.

currently the buttons will do nothing except error in console:
TypeError: search.split is not a function

need to:

• check that $location.search() returns arrays when query param keys are duplicated
• convert $scope.search to an array if it's not an array
• include documentation about how to write mapping()s that take arrays by default

ASCII ampersands in queries are prematurely terminating the kw parameter in requests; all text after the ampersand character is not included in the external search.