alpha-fi / cheddar-auction Goto Github PK

Should panic if it calls not by owner_id

• HashMap is good and works fine, but for all state changes operations requirement is paid (resourses, processing time) and using HashMap has less efficiently using. Inside the ContractState all keys for HashMap elements will be store into Contract at separative Object(keys) and will be Serialize-Deserialize for each call. We don’t need Serialize-Deserialize processes to whole map, we need just one element taking per Payout call. I propose to use UnorderedMap instead of HashMap:

• How storage_management realized? Why it removed, v1_cheddar_auction.testnet (which last updated as I see) didn’t have any StorageManagement?

• better using env::predecessor_id() its more efficiently because of less size of msg parsed and can be compared in asserts without calling as_ref() or to_string()
  

  cheddar-auction/nft-auction/src/nft_callbacks.rs

  Line 35 in ee01b6d

  let SaleArgs { period, token_type, price, nft_contract_id } =

first time -

use like this:

if bids.len() + 1 > self.bid_history_length as usize {
   bids.remove(0);
};
//and then:
bids.push(new_bid);

• How about gas? FT transfer get 5Tgas, each callback - 5Tgas. What if it will be more than 20 accounts to refund FTs, for example? Or it covered on front-end?

• Here you are have limit - max payouts is 10

  cheddar-auction/nft-auction/src/sale.rs

  Line 194 in ee01b6d

  10,

  
  Why you are remove check for this at callbacks? If it will be more than 10 payout accounts (I think if we are use FTs more than 7-8) it panics with “Exceeded prepaid Gas”. And refunds actions can go bad in that case:

  cheddar-auction/nft-auction/src/sale.rs

  Line 255 in ee01b6d

  self.refund_bids(sale.bids);

• Where it used, or will be? -> payout.with_cheddar