alphagov / fabric-scripts Goto Github PK

DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.

Related: upgrading from Fab scripts version to version 2.

As mentioned by @dcarley in #166:

Might be worth adding a linter and TravisCI to this project. Not as part of this PR, but later..

When running the emergency publishing task, it asks that you enter some information:

Heading
Short description
More info link

If one of those inputs is a unicode character, such as including a quote ' mark, then it fails with the following error:
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 10: ordinal not in range(128)

$ fab production cdn.purge:/foo
[cache-1.router] Executing task 'cdn.purge'
[cache-1.router] run: curl -s -I -X PURGE http://localhost:7999/foo | grep '200 Purged'
[cache-1.router] out: HTTP/1.1 200 Purged
[cache-1.router] out:
[cache-1.router] out:

[cache-2.router] Executing task 'cdn.purge'
[cache-2.router] run: curl -s -I -X PURGE http://localhost:7999/foo | grep '200 Purged'
[cache-2.router] out: HTTP/1.1 200 Purged
[cache-2.router] out:
[cache-2.router] out:

[cache-3.router] Executing task 'cdn.purge'
[cache-3.router] run: curl -s -I -X PURGE http://localhost:7999/foo | grep '200 Purged'
[cache-3.router] out: HTTP/1.1 200 Purged
[cache-3.router] out:
[cache-3.router] out:


Done.
Disconnecting from jumpbox.production.alphagov.co.uk... done.
Disconnecting from cache-3.router... done.
Disconnecting from cache-2.router... done.
Disconnecting from cache-1.router... done.

I would expect cdn.purge to purge the CDN, i.e. Fastly. Instead, possibly because cdn.py imports from the cache module, cdn.purge purges our own Varnish instances.

Can anyone let me know if they've seen this before or can reproduce it? I'm banging my head against a wall.

• OS X 10.10.5
• Homebrew

brew info python # python: stable 2.7.11, HEAD
pip --version # pip 8.0.2 from /opt/boxen/homebrew/lib/python2.7/site-packages (python 2.7)
virtualenv --version # 14.0.1

Inside a new virtualenv:

which python # /Users/alexmuller/.virtualenvs/fabric-scripts/bin/python
which pip # /Users/alexmuller/.virtualenvs/fabric-scripts/bin/pip
pip install -r requirements_for_tests.txt
which fab # /Users/alexmuller/.virtualenvs/fabric-scripts/bin/fab
fab -l # works fine!
fab integration
# Illegal instruction: 4

Using Fabric without a virtualenv is fine.