alphagov / forms-runner Goto Github PK

What analytics? Anne to confirm here https://trello.com/c/d9eXIVLO/438-ensure-minimum-user-insight-events-are-being-tracked

Change form pages to use HTML forms to display and receive data.

What about shared browsers in a library?

Is this a pentest recommendation?

https://www.w3.org/TR/WCAG21/#timeouts

https://www.w3.org/WAI/WCAG21/Understanding/timeouts.html

https://www.w3.org/TR/WCAG21/#timing-adjustable

https://design.tax.service.gov.uk/hmrc-design-patterns/service-timeout/

we use redis

Currently the govuk-frontend assets (most noticeably the GDS Transport font) aren't being compiled by the asset build. This means that the fonts and assets will load correctly on a local machine, but return 404s on the dev server.

This should include anything we're likely to need in both forms-admin and forms-runner, but not anything more specific. We already have a default Rollup build but this may also need a but of configuring.

This should include:

• babel for transpiling
• a browserslist configuration (start with a sensible default, we will adjust this later once we have a better idea of our user stats)
• jest for unit testing
• cypress for end-to-end testing
• style and js linting
• autoprefixer
• dart-sass instead of ruby-sass
• install govuk-frontend
• style and js formatting

• The user can see a summary of their answers and the questions they relate to
• The user can click on the "change" link to the side and be taken to the page
• Having clicked on the "change" link, the "back" button in the page takes them back to the check your answers page
• When submitting updated information, they're redirected back to the check your answers page

We want a github action to run against every pull request, this should include:

• Running the tests
• Running linting
• Bundler audit

We want to use sentry for exception tracking, we will need to set up a sentry account and ensure the service can send exceptions correctly

GDS has a standardised README format. We should use this in our repositories.

This should include:
404 for page not found
500 for unexpected errors
Service unavailable (in case we need to take the service down temporarily)
Notify error (special case of the 500 error with some extra text about the submission failing)

https://design-system.service.gov.uk/components/phase-banner/

cache expiry set to 72000s (20h)?

do we need to tell the user the expiry?

We need to prevent search indexing so that users don't accidentally access the form pages directly - see Ensure users start their journey on GOV.UK in the Service Manual. We can either do this with a meta tag in the view or by adding the X-Robots-Tag HTTP header.

We want this to apply to all pages on the runner. Adding the header in AppliccationController will probably make require less maintenance in the long run, as we are marginally more likely to add new layouts than we are to add new controllers that don't inherit from this one.

forms-runner is returning a 500 http response code in situations when a 404 would be expected, e.g.

{RUNNER_BASE}/this-should-return-a-404

To ensure the design system has been set up correctly, we want to add the design system to the existing layout for the page

Trello card: https://trello.com/c/d9eXIVLO/438-ensure-minimum-user-insight-events-are-being-tracked-in-logs

Add entries to the logs for some core user journey events. To start, log when a user:

• Visits the root form URL
• Saves the first page of a form
• Saves subsequent pages of the form
• Hits the Change Your Answers page
• Changes an answer (i.e. saves a page after going back from the Change links on the Change Your Answers page
• Submits the form

The logged information will be:

• event name
• request URL
• HTTP method
• form name
• question text (if saving an answer to a question)
• user agent string

Part of Spike: Allow user to create a form with a title that sends email to GOV.UK Notify

Trello backlink https://trello.com/c/xewAy5s7/123-spike-allow-user-to-create-a-form-with-a-title-that-sends-email-to-govuk-notify

End User can press a button that sends an email using Notify, including the title, text input, and submission time

As a result of alphagov/forms#38 discussion

• Add simplecov to record coverage
• Setup sonarcloud to link to this repo
• New PR get a report of coverage and any smells

Part of Spike: Allow user to create a form with a title that sends email to GOV.UK Notify

We would like to automatically deploy to the dev environment on merge into main