Issue by bestie
Friday 14 March 2014 at 15:56 GMT
Originally opened as #44

• Removed use of #helper_method in favour of explicit locals
• Removed complex #documents method which was hard to understand

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/44/commits

Issue by heathd
Wednesday 19 February 2014 at 14:30 GMT
Originally opened as #12

If a path is present in the artefact then panopticon will register the
artefact with the router upon publication. Note that specifiying 'path'
causes an exact path route to be registered (as opposed to a prefix
route).

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/12/commits

Issue by elliotcm
Friday 14 February 2014 at 14:18 GMT
Originally opened as #4

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/4/commits

Issue by heathd
Monday 24 February 2014 at 12:25 GMT
Originally opened as #14

This updates the content models gem to a version which stores SpecialistDocumentEditions in a separate collection. Given that content-api is already using this newer gem version, the publishing operation is not currently working (data is getting stored in one place and read from another).

This is the minimal set of changes to get publishing working for now.

Would be good if @elliotcm and @bestie could review and merge if it will not cause too many conflicts with the refactoring work in progress.

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/14/commits

Issue by bestie
Tuesday 25 February 2014 at 12:20 GMT
Originally opened as #17

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/17/commits

Issue by heathd
Monday 03 March 2014 at 12:45 GMT
Originally opened as #23

Not sure what the thinking was behind .tap, it will always execute the
block.

Added a cucumber scenario for this as well, although that might be
better covered by a lower level test.

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/23/commits

Issue by elliotcm
Wednesday 19 February 2014 at 14:11 GMT
Originally opened as #11

https://www.pivotaltracker.com/story/show/65351132

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/11/commits

Issue by heathd
Thursday 27 February 2014 at 12:06 GMT
Originally opened as #20

It should have been called a repository as that's the pattern we're
following:

http://martinfowler.com/eaaCatalog/repository.html

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/20/commits

Issue by heathd
Tuesday 18 February 2014 at 11:08 GMT
Originally opened as #7

Uncle Bob said "Depend on abstractions, not concretions". This is the D
in the SOLID principles of OO design[1]

A dependency injection container makes life a little easier when
following the dependency injection pattern. It holds dependency
configuration ("wiring"), and implements conventions for
fulfilling object dependencies, as follows:

1. constructor injection

   the container will use the names of constructor arguments and find
   dependencies with the corresponding name

2. struct member injection

   since we commonly use Structs as value objects, the container also
   supports struct members as dependency definitions

Different containers can be used in different contexts (for example in
production vs. test).

[1] http://en.wikipedia.org/wiki/SOLID_(object-oriented_design)

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/7/commits

Issue by bradwright
Monday 24 February 2014 at 15:32 GMT
Originally opened as #15

None

bradwright included the following code: https://github.com/alphagov/specialist-publisher/pull/15/commits

Issue by heathd
Tuesday 18 March 2014 at 18:24 GMT
Originally opened as #48

Add convenient links to view published cases.

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/48/commits

Issue by heathd
Thursday 13 February 2014 at 18:22 GMT
Originally opened as #3

https://www.pivotaltracker.com/story/show/65351132

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/3/commits

Issue by edds
Thursday 06 March 2014 at 11:59 GMT
Originally opened as #33

• Copy styles over for the preview. This will hopefully eventually be in
  the frontend_toolkit but it will want iterating before then.
• Put a box around the preview so you know what it is.

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/33/commits

Issue by edds
Tuesday 18 March 2014 at 14:14 GMT
Originally opened as #47

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/47/commits

Issue by heathd
Monday 03 March 2014 at 14:04 GMT
Originally opened as #24

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/24/commits

Issue by elliotcm
Thursday 13 February 2014 at 17:12 GMT
Originally opened as #2

https://www.pivotaltracker.com/story/show/65351132

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/2/commits

Issue by bestie
Thursday 13 March 2014 at 12:41 GMT
Originally opened as #38

This massively bloated PR includes

Attachment functionality

• Attach files to document
• Generate markdown snippet for body
• Convert snippets into standard markdown

Publisher rendering / exporting

• Publisher is now entirely responsible for rendering it's own content into HTML
• Rendered content is exported via writing rendered document data to the RenderedSpecialistDocument collection

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/38/commits

Issue by heathd
Friday 14 March 2014 at 10:52 GMT
Originally opened as #41

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/41/commits

Issue by elliotcm
Wednesday 19 February 2014 at 11:23 GMT
Originally opened as #9

Introduces more markup from @edds around inline error messaging.

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/9/commits

Issue by elliotcm
Thursday 13 February 2014 at 14:10 GMT
Originally opened as #1

https://www.pivotaltracker.com/story/show/65349700

Finder slug currently hardcoded to CMA.

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/1/commits

Issue by heathd
Monday 03 March 2014 at 11:13 GMT
Originally opened as #22

This is a partial fix for bugs which prevent published documents from being visible through the frontend.

The next part is in
alphagov/govuk_content_api#163

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/22/commits

Issue by bestie
Friday 14 March 2014 at 11:10 GMT
Originally opened as #43

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/43/commits

Issue by elliotcm
Tuesday 11 March 2014 at 16:20 GMT
Originally opened as #36

https://www.pivotaltracker.com/story/show/65362466

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/36/commits

Issue by elliotcm
Tuesday 04 March 2014 at 13:11 GMT
Originally opened as #29

https://www.pivotaltracker.com/story/show/66787414

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/29/commits

Issue by elliotcm
Tuesday 04 March 2014 at 10:21 GMT
Originally opened as #27

https://www.pivotaltracker.com/story/show/65353190

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/27/commits

Issue by fatbusinessman
Tuesday 04 March 2014 at 10:50 GMT
Originally opened as #28

These break a bunch of Unix-y tools (starting with cat) and cause Git to complain in diffs.

fatbusinessman included the following code: https://github.com/alphagov/specialist-publisher/pull/28/commits

Issue by elliotcm
Friday 14 March 2014 at 09:55 GMT
Originally opened as #40

https://www.pivotaltracker.com/story/show/67105612

This is rough & ready, cases need to start importing today.

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/40/commits

Issue by edds
Tuesday 18 March 2014 at 11:51 GMT
Originally opened as #46

The previous help wouldn't have worked if you had used it.

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/46/commits

Issue by bestie
Wednesday 05 March 2014 at 13:37 GMT
Originally opened as #31

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/31/commits

Issue by elliotcm
Wednesday 19 March 2014 at 10:49 GMT
Originally opened as #49

https://www.pivotaltracker.com/story/show/67773190

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/49/commits

Issue by bestie
Tuesday 25 February 2014 at 16:15 GMT
Originally opened as #18

Turned into a quite a refactor of SpecialistDocument and SpecialistDocumentRegistry.

SpecialistDocument now acts as a container for a collection of editions, pointing to the 'latest' one and acting as a proxy for it.

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/18/commits

Issue by edds
Tuesday 18 February 2014 at 16:37 GMT
Originally opened as #8

So that there is some indication of non-field errors.

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/8/commits

Issue by heathd
Thursday 13 March 2014 at 17:41 GMT
Originally opened as #39

debugger doesn't work properly in ruby 2.0

cldwalker/debugger#47

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/39/commits

Issue by edds
Monday 17 February 2014 at 13:29 GMT
Originally opened as #6

Add some styling to the errors so you know what is going on.

This will look better when this pull request is merged against the generic_form_builder.

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/6/commits

Issue by elliotcm
Monday 03 March 2014 at 15:52 GMT
Originally opened as #26

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/26/commits

Issue by bestie
Sunday 16 March 2014 at 01:29 GMT
Originally opened as #45

Factory methods from DepenencyContainer are usually used in a private
or protected context so it makes sense for the visiblity to be
configurable and have a sensible default (private).

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/45/commits

Issue by bestie
Tuesday 25 February 2014 at 12:12 GMT
Originally opened as #16

These gems are both really useful for development, I absolutely hate being without them.

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/16/commits

Issue by elliotcm
Friday 14 February 2014 at 16:03 GMT
Originally opened as #5

These are subject to change.

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/5/commits

Issue by bestie
Wednesday 12 March 2014 at 16:34 GMT
Originally opened as #37

This allows Rake to have a different output format from when Cucumber
is directly invoked from the command line.

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/37/commits

Issue by bestie
Wednesday 05 March 2014 at 13:34 GMT
Originally opened as #30

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/30/commits

Issue by heathd
Wednesday 19 March 2014 at 12:08 GMT
Originally opened as #50

this is needed so that CMA can start properly tagging the data in publisher

https://www.pivotaltracker.com/story/show/67733978

Case type

Case state

Market sector

Outcome type

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/50/commits

Issue by heathd
Wednesday 05 March 2014 at 17:56 GMT
Originally opened as #32

Our own implementation was wrong because it specified the wrong user
collection (the default one called 'users'). I'm not sure what data
actually is in that collection, possibly it's historical data that's no
longer used by any app.

We need to store in a separate mongo collection defined by the
USER_COLLECTION_NAME constant.

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/32/commits

Issue by edds
Friday 07 March 2014 at 13:01 GMT
Originally opened as #34

edds included the following code: https://github.com/alphagov/specialist-publisher/pull/34/commits

Issue by heathd
Wednesday 19 February 2014 at 11:43 GMT
Originally opened as #10

this is passed through to the router so it knows
where to pass requests.

heathd included the following code: https://github.com/alphagov/specialist-publisher/pull/10/commits

Issue by bestie
Monday 03 March 2014 at 11:12 GMT
Originally opened as #21

Preview can be generated by page refresh which saves the document or by XHR when javascript enabled.

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/21/commits

Issue by elliotcm
Monday 03 March 2014 at 15:30 GMT
Originally opened as #25

Slugs with trailing hyphens fail validations (and are a bit ugly).

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/25/commits

Issue by bestie
Friday 14 March 2014 at 11:00 GMT
Originally opened as #42

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/42/commits

Issue by elliotcm
Friday 21 February 2014 at 13:23 GMT
Originally opened as #13

https://www.pivotaltracker.com/story/show/65349700

elliotcm included the following code: https://github.com/alphagov/specialist-publisher/pull/13/commits

Issue by bestie
Wednesday 26 February 2014 at 10:20 GMT
Originally opened as #19

• Add SpecialistDocumentBuilder
• Add DependencyContainer methods to Cucumber World

Builders are a new pattern for this application and I've put them in models/builders. I'm open to other suggestions.

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/19/commits

Issue by bestie
Monday 10 March 2014 at 10:37 GMT
Originally opened as #35

Once a document becomes published the slug, which determines the URL, on subsequent editions is not allowed to change.

Needs styling

https://www.pivotaltracker.com/story/show/67019028

bestie included the following code: https://github.com/alphagov/specialist-publisher/pull/35/commits