amaabca / sensitive-param-filter Goto Github PK

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update All Dependencies (actions/checkout, actions/download-artifact, actions/setup-node, actions/upload-artifact, eslint, jest)

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

I was trying to use the filter in blue-node-utils in order to console log the error. However, that object contained a _headers key that had all the headers in its value as a string, and therefore the Bearer Token was exposed. Until this is fixed, I decided to not log that error anymore.

Describe the bug:
Passing a Map or a Set to SensitiveParamFilter turns theses data structures into an empty object (printed as {}).
I would expect that a Set remains unchanged (as it is the case for arrays) and a Map is converted into an object with the same keys as the Map and the values filtered if necessary.

Sample Reproduction:

  // NOT OK
  const filter = new SensitiveParamFilter()
  console.log(
    filter.filter([
      "map test",
      new Map([
        ["Password", 143534],
        ["345", 2],
      ]),
    ]),
  )
  // Output: [ 'map test', {} ]

  // NOT OK
  console.log(filter.filter(["set test", new Set(["123", "Password"])]))
  // Output: [ 'set test', {} ]

  // OK
  console.log(filter.filter(["array test", ["123", "Password"]]))
  // Output: [ 'array test', [ '123', 'Password' ] ]

  // OK
  console.log(
    filter.filter([
      "object from map test",
      Object.fromEntries(
        new Map([
          ["Password", 134545],
          ["345", 2],
        ]),
      ),
    ]),
  )
  // OUTPUT: [ 'object from map test', { '345': 2, Password: 'FILTERED' } ]

Travis CI is not setup correctly - this needs to be fixed.

Describe the feature:
Some form of autocomplete should be used, so that, when using the library, suggestions are automatically made by the IDE

Use Cases:
When typing new SensitiveParamFilter( in VSCode, it would be great if the different options that could be passed in appeared in a tool-tip.

Example:
N/A

Are you willing to make a pull request to implement this feature?
Yup! Might be a while, but it should happen eventually.