amadeusitgroup / amc Goto Github PK

Before waiting for completion of C++20 support of constexpr memory allocation, we can improve FixedCapacityVector in order to make it 100 % compatible with constexpr as it does not allocate memory.

It would be great if we could have a code coverage metric for the unit tests.

Currently vectors swap methods only swap the contents of the vectors, without touching each other's Allocator.
Standard defines allocator trait propagate_on_container_swap to control this behavior.

see std::set::find overloads from C++14.

Since C++17, std::vector may be declared with incomplete types. However, it's not the case for amc::vector as it shares some parts with amc::SmallVector and amc::FixedCapacityVector which require complete types.

Allow definition of amc::vector with incomplete types.

More information here

The benchmark report shows ~20ns average lookup time for std::unordered_set, which is less than the time taken by a cache miss, therefore unrealistic for average sized sets. The benchmark uses sets of 100k elements, a std::unordered_set of 100k int32 barely fits in L3 cache and the benchmark makes it look too good in comparison with amc::FlatSet.
I suggest to use bigger set sizes, or repeat the benchmark for different set sizes.

Readme is explaining the core contents of the library but can be improved:

• Add example of usages of each container, why it exists and in which cases it can be useful
• Explain how to consume the library in a C++ project (for instance with FetchContent) with code integration examples

vectors tests is a bit complicated with large functions and should be broken down in smaller tests to ease readability.
We would then be able to see if all the features of the class are properly tested.

Implement helper function amc::erase_if behaving like std::erase_if

assign_range, insert_range(https://en.cppreference.com/w/cpp/container/vector/append_range)

std::set comparison operators are templated and should accept other types of sets than only Self.