I have tried promise, await for loop, async, and await doesn't work in input.py

let me explain below

in line 83 in input.py

for await (URL of AllUrl) {
 
dispatch({ type: 'CardLoading', data: true }); //  it should be true so append loading in oneVideo function
 // some code
}

dispatch({ type: 'CardLoading', data: false });  // once it is done then it should be false remove loading but 

the result is remove loading in 1 sec without show loading in the frontend

can't figure out how to fix it? can you fix it? @raulpy271

there are 3 main url in youtube

url 1 : https://www.youtube.com/watch?v=........... (11 char) - one video

url 2 : https://www.youtube.com/watch?v=........... &list=.............................(11 char in watch and 34 char in list) - Playlist

url 3 : https://www.youtube.com/playlist?list=................................ (34 char in playlist) -Playlist

If url is same as url 1 then it should true and run function ( one video funtion )

else if url is same as url 2 or url 3 then it should true and run function ( multiple video function )

otherwise it will popup wrong link

I am able to figure out how to do it by using regex here is code below:

https://github.com/amantiwari1/youtube-GUI/blob/8fb1983c7387fe1553a4b5d96eee8eb22b92ec1b/src/components/Input.tsx#L74-L140

But Main issue
if more than 11 char then it return true which is wrong that mean regex is wrong ,
and cant figure out how to use url 2 in regex

can you help me for this? @raulpy271

@amantiwari1, I'm having the same problem that we discussed in #3. Can I update the code to use a list? I need to fix it on my machine before fixing the download problem.

Why every time that the user adds a new video link the backend add the new video in the db and then queries all video and set all video in the interface?

Is most useful to query only the new video and then add it using DetailsReducer with the action add. With this method, we save some queries in the db.

@amantiwari1, what is your opinion?

In the last pull request (Added 'Add' btn) we change the behavior to handle a single url by time, but we don't change the behavior of this function, which act as the text area has a list of url.

To change it, I refactored this function in the branch refactor. After the merge of this pull request #12, we can merge this branch too.

To call ffmpeg, the code downloadvideo.py use the method call of the lib subprocess. See an example:

subprocess.call(f'ffmpeg.exe -y -i "{vidname}" -i "{audname}" -c:v copy -c:a aac "{outname}"', shell=True)

In my machine, this raises an error because the command should be passed in a list, like this:

subprocess.call(['ffmpeg', '-i', 'input.avi', 'output.mp4'])

@amantiwari1, what do you think?

When I select the video quality higher than 480p the app gives me it: size: NaN undefined.

I merged in my local branch the code from the main branch, And when I try to run the app, It raises the following error:

sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) no such column: video.savefile
[SQL: SELECT video.id AS video_id, video.url AS video_url, video.title AS video_title, video.thumbnail AS video_thumbnail, video."downloadPercent" AS "video_downloadPercent", video.videoquality AS video_videoquality, video.savefile AS video_savefile 
FROM video]
(Background on this error at: http://sqlalche.me/e/14/e3q8)

I didn't try to solve it, @amantiwari1 did you have any idea?

If the user inserts a valid link to a single video the app shows the card of the video, but also shows the message: 'Please enter a valid YouTube URL'.

Root of the error: Before the commit 356ffbc the state of the cards is changed in the frontend (for the functions oneVideo and onePlaylist). After the above commit, the functions Add_Details and Get_Data_Details_Playlists also change the state. So, the frontend functions expects that the backend returns some data, which not happens, so the frontend concludes that the link is invalid.

Also, this error is from a bed conceptual idea: the backend doesn't should change the state of the interface, this is a role for the frontend. The MVC(and whatever similar pattern), divide the application into layers to turn easy to understand and to turn clear the role of each layer. If the backend could change the state of the interface then it's breaking the principles of a layered system, because the backend should change the database and the frontend should change the state of the front, not the other way around.

So my solution is the following: the function Add_Details and Get_Data_Details_Playlists should return the data of the videos while the function oneVideo and onePlaylist should set the state.

@amantiwari1, what do you think? I'm not a master in MVC, actually, I didn't read much about it, so feels free to fix me in some points.

we need to change bad code to good code in download function

first we need to understand this function

try download 10 mb video, you will find downloading is still here in frontend while backend said already done download

I dont know where is issue in download function? i copied that function from stackoverflow😂

let me know did you find issue once download 10 mb!!
@raulpy271

We will use library called SQLALCHEMY. this library allows to make CRUD easier and ORM for create table easier and MVC is an architectural pattern that separates an application into three main logical components: the model, the view, and the controller.

I will create models folder to create new table, we have already view named src folder

I change the method to check url's in this #8 pull request, even using this method, we can't check if the value of the params v and list represent a video, because the params can have the exact match but the video no necessarily exist. So we need to check it in the backend.

I guess that idea to have a single text area to paste different url's is bad.

Because every time that the user pastes a new url the app will have to handle old and news urls. It will have to decide which url is new or not. These increase the processing and complexity of the application. Besides, the app has to handle any change, for example, if the user adds space or a new line the app will process all links already processed.

To solve it I propose the following: Create an 'Add' button before the download button. So the app will handle a link only when the user clicks on it. Besides, the text area will have only a link by time.

These will work this way: The user inserts a link and clicks on the add button, if the link is correct the app will show the video/playlist card and clear the text area. After it, the user can insert a new link or download these inserted.

With these changes, the app will process less because it won't process links already processed. Besides she won't care about useless changes (as space added), it will only when the user clicks on the 'Add' button.

@amantiwari1, what do you think about it?

@amantiwari1,

I changed the regex's of issue #5, but when I insert a valid URL I'm getting the following error:

TypeError: can't convert undefined to object

  111 | 
  112 | console.log(message)
  113 | if (message !== true) {
> 114 |     SetAllDetail({ message, type: 'add' });
      | ^
  115 | }
  116 | setCardLoading(false)
  117 | 

I printed the value of message and it is null. Even before the changes that I did today the error already exist.

Did you want that the app to also be a video player?