Giter VIP home page Giter VIP logo

fkf-garbage-collection-card's People

Contributors

amaximus avatar nemethloci avatar wrt54g avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

Forkers

quiethu

fkf-garbage-collection-card's Issues

Doesn't work outside HACS

The card can't load the translations when installed manually, since it expects a hacs path:

this.translationJSONobj = "undefined";
const translationLocal = "/hacsfiles/fkf-garbage-collection-card/" + this.llocale.substring(0,2) + ".json";

From what can I see in the code, it has some support for the cases when it fails to load the translation, but translationJSONobj is initialized to "undefined" (a string), which means the if here won't catch it:
if ( typeof this.translationJSONobj != "undefined" ) {

(its type will be string, not undefined), and then fail when it tries to index the string. translationJSONobj should be initialized to undefined, but I have no idea how can you get the path to your js file (if it's possible at all).

Items arrangement

Currently the items on the card are misaligned, compared to other standard lovelace cards:
kép

Suggestion:
kép
(+writing the first character uppercase)

Card causing high load

I'm using a Samsung Galaxy S5 Mini mounted on the wall running LineageOS and WallPanel app to display Lovelace.
When I add fkf-garbage-collection-card to the UI, the whole interface becomes very slow and laggy. Touching other controls like switches, covers etc barely react, state change feedback comes after minutes delay.
As soon as I remove fkf-garbage-collection-card from the dashboard, everything turns back to normal.

dark_mode: true
entity: sensor.fkf_hulladek
hide_date: true
items_number: 3
type: 'custom:fkf-garbage-collection-card'

Tried with LineageOS built on Android 7.1.2, and Android 9, behaves exactly the same. The phone is in a closed WiFi network without access to the internet, only accesses Home Assistant and NTP server on the same network. Home Assistant runs on an Xenon-based ESXi server VM.

"days" localization

Angolul jelenik meg hogy "days":
kép

Egyelőre kézzel javítom ki frissítés után (${attribute.indays} nap)

Köszönjük!

Extension for Budaörs

Dear Author,

Could you please extrend your program to process the garbage collection schedule in Budaörs, please?
It works similar like FKF at Budapest, couple differences noticed:

  1. URL is different: https://www.fkf.hu/hulladeknaptar-budaors
  2. There is only one parameter in request (street name, like: Alma utca)
  3. Here all the three types of waste (communal, selective and green) is included in the given resoult for the next 1 month.

Many thanks in advance!
hundavide

Error in the green waste query in Budaörs

In the case of Budaörs, it queries the 3 types of waste with one single query, as far as I can see from the code, the problem may be that in the case of Budapest there are 2 separate requests 1. for municipal and selective and 2. for green waste. When the extension was written in winter there was no green waste, so this difference in the result didn't come up in the testing. Two result files are attached: the list from FKF (https://www.fkf.hu/hulladeknaptar-budaors) and the list queried by HA with the current code. For testing "Árvácska utca" was used.
01
02

Icon color

Please implement usage of inverted colors for icons when theme/background is dark:
kép
I temporarily fix it by changing to --iron-icon-fill-color: white;

Köszönjük!

Layout revamp ideas

I really like this card so far, thank you very much for it!

My suggestion is to rearrange the table columns to achieve a more streamlined look that could help digesting the information easier.

The column order could be:
|icon1| |icon2| |description| |date| |weekday| |numberofdays|

Left: Current
Right: Suggestion (with one_icon: true and w_day: false)

layout_redesign

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.