ambitioninc / django-manager-utils Goto Github PK

Currently manager utils requires that managers inherit MangerUtilsManager in order to take advantage of the functionality in manager utils.

Update the interface so that users can also do the following:

from manager_utils import bulk_upsert

bulk_upsert(queryset, list_of_upserts, unique_fields, update_fields)

Basically, the user should be able to provide querysets to all of the functions in manager utils. This is useful for models in third-party applications that do not inherit ManagerUtilsManager

I just spent an hour tried to debug an error only to find out that django-manager-utils doesn't support MySQL. This should be mentioned in the readme that MySQL is not supported. Submitting this issue to udpate Readme for the same.

Create a sync() function. Similar to bulk_upsert, sync() should do a bulk_upsert() but also delete any objects not found in the queryset being synced. For example,

Account.objects.all().sync([list of accounts], unique_fields, update_fields)

After accounts have been synced, they should contain exactly the accounts in the list of accounts provided.

Hey Wesley!

Nice work done here, congratulations...!

I was starting to write a code that is somewhat similar to the bulk_upsert function from your code, but relying on the native DBMS UPSERT implementations (PostgreSQL 9.5 specially), where instead of two separate queries (bulk_create and bulk_update), the whole operation would happen on a single upsert query.

Do you sometime have considered using it? I think this would be a great performance improvement for the Django ORM!

As soon as i have a more stable version of my code i'll let you know so you can maybe collaborate!

I am trying to use bulk_upsert with django ORM. I am using MySQL database as my backend. It does the insert part when some new rows are added but every time I triy to do an update using the update_fieldslist it throws an error complaining that the MySQL syntax is wrong:
'''
django.db.utils.ProgrammingError: (1064, "You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'FROM (VALUES
'''

When I tried to debug this further I realized that manager_utils uses django-query-builder which is build for postgre sql by default.
Any help would be greatly appreciated. Thanks

Akshar Ranka

There is sqlite support in the test rig, however there are imports and usage of JSONField and ArrayField, which are postgres specific fields.

In bulk upserts, the user needs to supply a uniqueness constraint. Right now manager provides allows duplicate entries for these uniqueness constraints in the input data.

It should actually throw an error when dups are found because such an input is actually invalid.