Giter VIP home page Giter VIP logo

Comments (7)

dirk-thomas avatar dirk-thomas commented on June 27, 2024

build_dependencies in this context (

for path in context.build_dependencies:
) are not the direct build dependencies of the package specified in the manifest. This list already contains all recursive dependencies in topological order (determined by
def topological_order_packages(
).

Therefore I don't think anything needs to be changed here?

from ament_tools.

dirk-thomas avatar dirk-thomas commented on June 27, 2024

Based on the output of #62 it looks like that the order is correct. The problem is that the environment files include not only the recursive dependencies but also downstream packages - basically all packages of the workspace.

from ament_tools.

wjwwood avatar wjwwood commented on June 27, 2024

@dirk-thomas But they should be skipped because they don't have environment hooks inside the workspace? or is it a problem when you install two workspaces to the same install space?

from ament_tools.

dirk-thomas avatar dirk-thomas commented on June 27, 2024

Sorry, I meant downstream packages. E.g. ament_cppcheck doesn't have any dependencies but currently uses the environment of all packages in the workspace (which is only the case when rebuilding a workspace again).

from ament_tools.

wjwwood avatar wjwwood commented on June 27, 2024

Oh, it's not just the dependencies, but also anything that comes before in the topological order.

from ament_tools.

dirk-thomas avatar dirk-thomas commented on June 27, 2024

It includes even packages which come afterwards in the topological order.

from ament_tools.

dirk-thomas avatar dirk-thomas commented on June 27, 2024

For packages with dependencies on other ament packages the list and order is correct. But for packages without dependencies on other ament packages the list contains all packages from the workspace. The fix is simple: #63.

from ament_tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.