Giter VIP home page Giter VIP logo

Comments (5)

amilajack avatar amilajack commented on August 17, 2024 1

@nmn Fixed this in a alpha version. I would really appreciate if you could test this out yourself and see if it address all the issues you have experienced:

from eslint-plugin-flowtype-errors.

amilajack avatar amilajack commented on August 17, 2024

See this note for the reason of the design decision.

Adding that feature is actually much harder than it seems and than it needs to be. ESLint's plugin API doesn't support.

Using flow check-contents you can pass...

Yup! I've actually used flow check-contents initially but there were issues with it. If I remember correctly, it was that flow check-contents would not return file paths, which are required for the plugin to work or it could have been that it would run on a file even if it didn't have the @flow pragma (Don't quote me on this).

The biggest drawback of this plugin is how you can't get errors before saving. I'll be working on getting this ASAP.

from eslint-plugin-flowtype-errors.

amilajack avatar amilajack commented on August 17, 2024

@nmn After looking into this, it seems like this has to do with the way that atom runs ESLint and its plugins. On some editors, you don't need to save for eslint to report errors. Check out this issue for more on that.

I'll contact the atom-linter/linter-eslint maintainers to see how I can resolve this.

from eslint-plugin-flowtype-errors.

amilajack avatar amilajack commented on August 17, 2024

@nmn Seems like it depends on your editor linter plugin.

A few people seem to have this working:
#8 (comment)
#8 (comment)

What editor and plugins are you using to integrate ESLint with your editor?

from eslint-plugin-flowtype-errors.

amilajack avatar amilajack commented on August 17, 2024

Sorry for the late follow up. 1.4.0 has been release. I would recommend using that instead. Also are you experiencing any issues with the module anymore? If not, maybe this should be closed?

from eslint-plugin-flowtype-errors.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.