Comments (8)
lluisrojass
commented on July 25, 2024
1
@amio will address in several hours. thank you :)
from re-carousel.
lluisrojass
commented on July 25, 2024
Created a PR to fix this bug #117.
from re-carousel.
amio
commented on July 25, 2024
@lluisrojass Thanks for raising this issue, I'll review the PR soon :)
from re-carousel.
lluisrojass
commented on July 25, 2024
@amio no problem, our project depends on this fix so please let me know about your findings.
from re-carousel.
amio
commented on July 25, 2024
Hi @lluisrojass , I left comment in #117 just now, sorry for the delay!
from re-carousel.
lluisrojass
commented on July 25, 2024
@amio I have updated the PR to function with both getDerivedStateFromProps (removing deprecated hook componentWillReceiveProps) and componentDidUpdate. I split to approach into the two hooks because we need access to the instance to refer to the frame refs in order to correctly position them, not possible in getDerived. This approach also limits the number of renders to only one. Doing this all in DidUpdate is just as trivial, but we would need one render to get new refs, then enter DidUpdate which would need to setState and cause an additional unnecessary second render.
from re-carousel.
lluisrojass
commented on July 25, 2024
@amio new commit addressing feedback is posted, also happy holidays!
from re-carousel.
amio
commented on July 25, 2024
@lluisrojass Thanks!
from re-carousel.
Related Issues (20)
- link does not jump in Ios browser HOT 2
- Strategy for Moving Widgets Outside Wrapper HOT 9
- Invariant Violation Error when Used in Storybook HOT 3
- Access to Current/Previous Frame Element HOT 7
- Use the keyboard to navigate between sliders HOT 4
- Animation Overlapping HOT 8
- [Violation] Added non-passive event listener to a scroll-blocking 'touchmove' event. Consider marking event handler as 'passive' to make the page more responsive. HOT 1
- Not swiping in my react app HOT 8
- [ touch idea ] disabling horizontal frame movement when scrolling vertically HOT 12
- Using styled-components HOT 2
- Jump to slide / Reset HOT 6
- basic example? HOT 1
- the component doesnt work when I install it through npm install then import it all i see is a blank screen HOT 2
- Add notes to readme/documentation on accessibility HOT 1
- Unable to change the style of the wrapper
- It always shows warning with string ref and doesn't show carousel HOT 1
- It doesn't work in Next.js HOT 1
- multi item catrousel HOT 1
- Cannot manage to find the npm package
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from re-carousel.