amirsanni / video-call-app-nodejs Goto Github PK

View Code? Open in Web Editor NEW

600.0 20.0 345.0 256 KB

A conference call implementation using WebRTC, Socket.io and Node.js

Home Page: https://chat.1410inc.xyz

License: MIT License

JavaScript 74.80% HTML 16.99% CSS 8.21%

webrtc nodejs socket-io javascript video-call chat-application conference-call

video-call-app-nodejs's People

Contributors

Stargazers

Watchers

Forkers

deawx yanchhuong midas-phoenix faisal-manzer vengixlabs glaubergoncalves rishabhporwal ensdmr12 ibwc saajidpasha anujm4467 bhu1oja mominnawaf naveenboda1993 urbanoex rachitgulati arfancitraw ranveermeel parths049 rakeshdrupal lucazin partikule parag4787 grajib23 eduardodinizweb harry-joshi ekpono ipay secretmoo35 yuttasakcom liebsen 1242035 omolewastephen igoronyshchenko logofic folkevil nomiscientist elhappymanny thecodeline karthikwebdev testbyuser23 medfrk sharmashubham850 thering999 lordmen99 saswatsamal anu1rag rama5789 awkward-minion tuannguyen90 sovann-paul prakharbhardwaj potux video-call victorray84 cmmishra ibalaji777 suyashcyber94 ccns1 flexcollab duncan-haywood w3ss projectworldsofficial sarancruzer elnatanv thongvm misheck1992 alamindev singhrajkr jaymj rahulroy0611 scriptfarm stevanslavnic max-keviv tecxra mfouadegy vn0 crunchy89 seyiogunjuyigbe carnival77 abijithsasikar97 kumaresank khorihutama ayushkurian himanshu-in buzzeins pmoajmer manunit ryanbekabe deepbratt burhanyilmaz linknetwork carlosa6 azizizulkipli trombed maheshruparel realboutouil vishnudk xploitspeeds durgacharannayak

video-call-app-nodejs's Issues

Facing issue when refresh a page feed call two time and display two feed of same user

<title>WebRTC Individual feed base on</title>

  function getPartnerNameFromUrl() {
    const pathSegments = window.location.pathname.split("/");
    return pathSegments[2];
  }

  (async function initWebRTC() {
    const partnerName = getPartnerNameFromUrl();
    if (!partnerName) {
      console.error("partnerName not found in URL");
      return;
    }
    let pc = new RTCPeerConnection(h.getIceServer());
    let socket = io("/stream");
    let username = "";
    let myStream = "";

    try {
      myStream = await h.getUserFullMedia();
      socket.emit("subscribe", {
        room: partnerName,
        username: username,
      });

      socket.on("newUserStart", (data) => {
        init(false, data.sender);
      });

      socket.on("ice candidates", async (data) => {
        if (data.candidate) {
          await pc.addIceCandidate(new RTCIceCandidate(data.candidate));
        }
      });

      socket.on("sdp", async (data) => {
        if (data.description.type === "offer") {
          await pc.setRemoteDescription(new RTCSessionDescription(data.description));
          myStream = await h.getUserFullMedia();
          myStream.getTracks().forEach((track) => {
            pc.addTrack(track, myStream);
          });
          let answer = await pc.createAnswer();
          await pc.setLocalDescription(answer);
          socket.emit("sdp", {
            description: pc.localDescription,
            to: data.sender,
            sender: username,
          });
        } else if (data.description.type === "answer") {
          // Ensure we're in the correct state to set the remote description
          if (pc.signalingState === "have-local-offer") {
            await pc.setRemoteDescription(new RTCSessionDescription(data.description));
          } else {
            console.error("Unexpected state for setting remote description:", pc.signalingState);
          }
        }
      });
    } catch (error) {
      console.error("Error initializing WebRTC:", error);
    }

    function init(createOffer, partnerName) {
      if (createOffer) {
        pc.onnegotiationneeded = async () => {
          let offer = await pc.createOffer();
          await pc.setLocalDescription(offer);
          socket.emit("sdp", {
            description: pc.localDescription,
            to: partnerName,
            sender: username,
          });
        };
      }

      pc.onicecandidate = ({ candidate }) => {
        socket.emit("ice candidates", {
          candidate: candidate,
          to: partnerName,
          sender: username,
        });
      };

      pc.ontrack = (e) => {
        displayRemoteStream(e.streams[0]);
      };
    }

    function displayRemoteStream(stream) {
      const existingVideo = document.querySelector(".remote-video");
      if (existingVideo) {
        existingVideo.srcObject = stream;
      } else {
        const partnerName = getPartnerNameFromUrl();
        const video = document.createElement("video");
        video.id = `${partnerName}-video`;
        video.srcObject = stream;
        video.autoplay = true;
        video.controls = true;
        video.className = "remote-video";
        const videoContainer = document.getElementById("videos");
        videoContainer.appendChild(video);
      }
    }
  })();
</script>

504 : Service Unavailable

The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.

Apache/2.4.41 (Ubuntu) Server at chat.1410inc.xyz Port 443

How many participant can be added in one room ?

I believe as this is a peer to peer communication there will be a limitation with the bandwidth and hence a number of participants allowed to be in a room?

If you have done the testing are you aware of how many can be allowed to be added in the room?
If I want to add such a limit that can be done on the server code. Correct me if I am wrong?

Regards,
Pravesh Bansal

How to store the recorded video into s3 bucket

chat not working

chat process not working

Have to work for more than 4 person

Hi,
i found that its not working for more than 3 person in same room.
Even tested your demo link https://chat.1410inc.xyz..
When more than 3 person are connected then

same person is displayed multiple times
or video call of person get delayed

Sometime there is blank screen for room no video is displayed.
I tried to use in my project but not able to use.
Can you help ?

why not working on public ip address?

why doesn't working on public ip address? Unique Identifier: not generate while calling from public ip address

403 Forbidden: Socket.io

Hello,

I followed all your instructions, but still not working on my server: https://letstalk.jmahuelgas.com/

Clone the repo
run npm install.
Ensure domain has SSL
New Ice server account

Note: I edited my document root folder permission into 777 and running on Apache.

Could you add a way to show all rooms available

Pleaase help in hybrid video conference app

Hello Amir, i followed your code from a long time, its so nice that u update projects time to time.

Amir i want to create a html5 css mobile hybrid app client of your nodejs conference app please guide.
Please explain what things are need to be port in mobile app and how to access socket server from remotely thru mobile device..
it may involve cors, how to bind cors to mobile app only..

please guide..

what to install for this???

I am unable to run this code.
how would I able too?

💥 Potential security vulnerability

A potential security vulnerability has been disclosed to your repo.
Plz visit url https://www.huntr.dev/bounties/1839f99e-8caa-4e7d-ad1a-b725379070a7 to see the report.
If you dont want to signup then provide your email address here #50 and report will be sent to your provided mail-address .
Also submitted a PR for Fix #51

node app.js is not running at all

Appreciating your nice project!
node app.js is not completing the command run. Is there any alternative way to run?

Error data.room

First run is ok. On reload script stop working. (Ubuntu. Chrome)

if ( socket.adapter.rooms[data.room].length > 1 ) {
                                             ^
TypeError: Cannot read properties of undefined (reading 'length')

have to work on local network

hello sir,

wonder full code , which i m looking for.. this is code working fine in localhost...

how could i change it to work between LAN

please help...

Code is not complete

The app is not working. I think the code is not same as demo.

Not working in Iphone

Hello Sir/Medam,

We are checking demo on our mobiles and it is working in android devices but not working in Iphone(Mac os). So anyone please give me a solution.

Thanks.

Not working with more than 8 people

Hi!
If you connect more than 8 people peers start gettin disconnected...

Unable to connect to Video when using Android device and iphone.

index.js:83 WebSocket connection to 'wss://chat.1410inc.xyz/socket.io/?EIO=3&transport=websocket&sid=de9bOZkoj4ZpmDsqACUg' failed:

Hi,

Thank you so much for building this!

I'm only having one issue. On my server I get the same console error as the below:

Any idea to work around this?

Thanks!

socket.io Method Not Allowed 405

Hi,

I followed all your points, but still not working on my sever: https://api.woo-interactive.com/

Clone the repo
run npm install.
Ensure domain has SSL
New Ice server account

mydoman.com/socket.io/?EIO=3&transport=polling&t=NFzVw6a [HTTP/2 404 Not Found 7

Hi the set up is working on localhost when i move to server am recieving that error on the console
mydoman.com/socket.io/?EIO=3&transport=polling&t=NFzVw6a [HTTP/2 404 Not Found 7

it seems socket.io is not available

When i tried to upload on heroku is gives error of logs like npm start than npm crash

Application error

2020-04-20T12:21:46.196792+00:00 app[web.1]: > [email protected] start /app
2020-04-20T12:21:46.196798+00:00 app[web.1]: > node src/app.js
2020-04-20T12:21:46.196799+00:00 app[web.1]:
2020-04-20T12:22:44.053438+00:00 heroku[web.1]: State changed from starting to crashed

2020-04-20T12:27:47.694247+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/"

heroku

Hello, sir
i am a student and want to test your app online.But when i tried to upload on heroku is gives error of logs.like npm start than npm crash

Trying to get in touch regarding a security issue

Hi there,

I couldn't find a SECURITY.md in your repository and am not sure how to best contact you privately to disclose a security issue.

Can you add a SECURITY.md file with an e-mail to your repository, so that our system can send you the vulnerability details? GitHub suggests that a security policy is the best way to make sure security issues are responsibly disclosed.

Once you've done that, you should receive an e-mail within the next hour with more info.

Thanks! (cc @huntr-helper)

File data communication

I am unable to pass the details of the newly added user from events.js to rtc.js and then to stream.js. I need to do to show the user names below the streaming videos of each user. I have tried everything, Can you please help me in achieving this. Maybe I might be asking silly thing but variable and values and communication amongst files, I found it difficult,

how to show users count in room?

Setting up the video and audio mute before joining to a meeting and showing up name on the video panel

Hi amirsanni, I am really so thankful to you for your video calling app code. I am trying to make some features like, before joining a meeting a user can choose options for muting audio and video, and in the video chatting section the user name(the name is already saved while joining) will be shown up when hovering the video panel. I have been trying to make these for a few days but can not get any way to do it. Now I think you can help me out.

Mobile browser issue

Hello Mr. Author,
Thank you for a good sample. Can you please help with this issue.
It does not support iPhone mobile browser? Any solution for this, please.
Thank you.

Cross Browser is not working

Hi Amir,

I tried your code it seems cross-browser is not working with this code.

Firefox screenshot

Chrome Screenshot

Case 1 ) Both the user is joining through Chrome or Firefox is working
Case 2 ) Cross-Browser Application is not working

Could you guide me with this ?

Regards,
Pravesh Bansal

deployment and users connection

hello sir
my question is how i can deploy this on ubantu server
and how much users can connect at a time

WSS handshake 400 error

Hi Amir,

Awesome project.

I am able to run the app on the same network but it seems that the connection is not being established on a remote server probably because the wss handshake is failing with 400 response. Please see the screenshot below:

Thanks in anticipation.

Video Quality

Good day. Can we change client's video quality? And how?

Give reference to xirsys.com to create own user.

Turn server used is provided by xirsys.com add creation of new account in README

Not working in node

Express was not defined

stream error: NotFoundError: Requested device not found

Hello, thank for your application,
but have one error in localhost and demo.

What can be the error?

same person is displayed multiple times

I don't know what is the problem but when the room has more than 3 visitors..
same person is displayed multiple times even in demo url...

Deployment

Hi
Your code is working very well, i tried to deploy in vercel now. Sh but am getting npm issue. Can you please tell about deployment. How to deploy and test the code in live

Video is not displaying while connected in Wifi

Hi Team,

I have used your code for video calling in my application. When i testing the application with wifi with other person the video of the second person is not visibling each other. But when we connect to the mobile network the video is displaying to each other. Let me know what will be the real issue on it.

Run via localhost

Hi good day, your project was awesome.

I tried your demo online, it was running smoothly. But, I intended to run in localhost. In my own machine is working fine, but when I network in a different machine (Windows 10, Updated Google chrome) it won't work as I assumed.

In the different machine, the error says that
"User media, not available".
backtrace:
at Object.getUserFullmedia(helper.js:65)
at getAndSetUserStream (rtc.js:108)
at rtc.js:37

I would like to add canvas feature to the web app .Please assign this issue to me .Thankyou

How to implement in Android Native

I am Android Developer and i need the video call application.So, can you help me ?
I have setup on my server and working fine.

But how can i manage to android mobile can you help me which api and how to join room using android Application or How to join any port or socket the i will join the video conference in android mobile.

Thank amirsanni

thank you.