Cannot succeed to create a PR about egit-extensions HOT 19 CLOSED

Hi Michel,

"Select Branch to Raise Pull Request" is a Default Info message which we are displaying on the wizard.

To Create PR please try follow the following steps.

1. Right Click on Branch, Click Create Pull Request.
2. Enter Title n Description.
3. On Left Side Combo select the branch to which you want to raise PR.
4. On Right Side Combo select the branch from which u want to raise PR.
5. Click on Create Button. You should see message "Pull request created Successfully..!"
   Plz refer to the screenshot below.
   

If you are still unable to create PullRequest please send us screenshot to [email protected] or [email protected].

Thanks,
Subramanyam.C.

from egit-extensions.

I understand that the message is the default message until you create the PR but so far clicking Create didn't trig any action. I'll check again and send you an email with the requested information if it still doesn't work.

from egit-extensions.

Hello Michel

Thanks for your email and also interest in eGit-Extension. I would recommend if you can also send us the eclipse .log file or a snapshot of the error log if u see that eGit-Extension plugin is triggering an error.

Coz we are using this plugin on day to day basis in Juno, Kepler, Indigo and dnt face an issue. It could be something that we wouldn’t have tried and definitely looking forward to fix it for you.

We can even do a skype call if you have the time to quickly fix it for you during a screenshare.

Regards

Malai

From: Michel Jouvin [mailto:[email protected]]
Sent: Thursday, April 03, 2014 5:49 PM
To: ANCIT/eGit-extensions
Subject: Re: [eGit-extensions] Cannot succeed to create a PR (#29)

I understand that the message is the default message until you create the PR but so far clicking Create didn't trig any action. I'll check again and send you an email with the requested information if it still doesn't work.

—
Reply to this email directly or view it on GitHub #29 (comment) . https://github.com/notifications/beacon/2596136__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxMjE0Njc2MiwiZGF0YSI6eyJpZCI6MjkwNDcxOTJ9fQ==--9a95c706496f0728fb9833cfe4e92ea5b9a505f5.gif

from egit-extensions.

Ok, I'll try to dig in the logs to see if I find something. Thanks for your Skype proposal, it is not easy for me these days but we can keep the option if needed. And thanks for providing this extension! This is really the missing bit in Mylyn. You should try to get it incorporated in the base Mylyn! Creating PR from Eclipse is (will be!) really cool!

from egit-extensions.

Stupid question! Where can I find useful Eclipse logs (I'm running on Windows if it makes a difference).

from egit-extensions.

You can find Eclipse logs in your workspace/.metadata folder.
Kindly send us the .log file.
Or You can goto ErrorLog View n export the log file.

from egit-extensions.

Found it! I remembered the error log view... that was absent from my current workspace.

So any attempt to select the PR destination raises the following error:

eclipse.buildId=4.3.2.M20140221-1700
java.version=1.7.0_45
java.vendor=Oracle Corporation
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=fr_FR
Framework arguments: -product org.eclipse.epp.package.standard.product
Command-line arguments: -os win32 -ws win32 -arch x86_64 -product org.eclipse.epp.package.standard.product

Error
Thu Apr 03 19:18:45 CEST 2014
Unhandled event loop exception

java.lang.IllegalArgumentException: Name cannot be empty
at org.eclipse.egit.github.core.RepositoryId.(RepositoryId.java:112)
at org.ancit.github.utils.pr.wizards.PullRequestWizardPage.getPullRequests(PullRequestWizardPage.java:478)
at org.ancit.github.utils.pr.wizards.PullRequestWizardPage$2.widgetSelected(PullRequestWizardPage.java:276)
at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1057)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4170)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
at org.eclipse.jface.window.Window.runEventLoop(Window.java:826)
at org.eclipse.jface.window.Window.open(Window.java:802)
at org.ancit.github.utils.pr.actions.RaisePullRequestAction.run(RaisePullRequestAction.java:34)
at org.eclipse.ui.internal.PluginAction.runWithEvent(PluginAction.java:251)
at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1057)
at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4170)
at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3759)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1113)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:997)
at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:140)
at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:611)
at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:567)
at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
at org.eclipse.equinox.launcher.Main.main(Main.java:1426)

Hope this helps.

from egit-extensions.

Thanks Michel for the log n required details. We will look into the issue n will fix it soon.

from egit-extensions.

Hi Michel,

Can u please share git configuration file. { Its available here repository/.git/config } We tried to reproduce your issue but we could not. We fixed other bugs. We will fix this issue also and will make a build and send an email notification for you.

from egit-extensions.

Fixed by Subbu and Build made on 15/04/2014. Awaiting Michel to confirm if he is able to raise a PR.

from egit-extensions.

I just tried the last release. the original problem is fixed but unfortunately I am still unable to raise a PR. When I click Create, I get the error 'not Found (404)'. I have no clue what the problem is... It'd be good to have a more explicit error message. There is nothing in Eclipse error log for this error.
BTW, I found a few minor issues:

• it'd be good to have the EGit extension remember the last target branch selected for a given source branch: this is a bit cumbersome to have to reselect it each time.
• Egit extension insists to have a non empty description field and propose to duplicate the title. For me this is unexpected as on GitHub nothing prevent you from creating a PR with an empty description if the title is enough. Duplicating the title doesn't make much sense IMO
• On GitHub, when you create a PR with only one commit, the commit description is used to pre-fill the title and description, with the title being the first line of the commit message and the description the other lines if any.

from egit-extensions.

Thks Michel. Your points are definitely of relevance. We would consider the same and try to fix them at the earliest. We will improve our error logging messages also.

from egit-extensions.

In EGitExtension, we are currently filling the Commit Description of the last few commits on click of the Down Arrow in Title. We can try to pre fill the 1st from that list itself. We have taken the Down Arrow approach from the Commit Window, where you need to press Ctrl + Space to get the description of the last few commits.

from egit-extensions.

I was wondering if you have been able to fix the issue preventing creation of PR? I have not seen any release of your PR for a while. Did I miss something?

from egit-extensions.

We have given a release on Friday with some bug fixes and your feature request. Please take some timeout to take an update. Awaiting your reply if it is working for you.

from egit-extensions.

Thanks, I'll let you know.

from egit-extensions.

It works! Thanks! I've been able to create a PR and check that the target branch was remembered. I still find discussable that the "description" is pre-filled with the title: I don't see any reason for duplicating the tile, nothing prevent the description from being empty. I'd suggest you mimic the GH behaviour which depends on the number of commits in the PR:

• 1 commit: the title is pre-filled with the first line of the commit description and the description with the remaining lines
• several commits: no default (in fact the branch name which is completely useless but ensure there is a non empty title)
  It also seems that there are still 2 minor problems:
• Description field should be multiline
• the "pull request" pane and the "commits", "file changes" remains empty. Any know reason for this?

from egit-extensions.

Hey

We hav even removed the prefilling. Just that i forgot to pull the
change into the build.
file changes pane is empty... we havnt implemented yet. But if you
already hav PRs in the branch that u have selected, it will list all the
PRs with the Commit Information.
And u can right click on the PR and copy it link or double click on the
Commit and it will open in a Browser.

Regards
Malai
On 6/9/2014 1:34 PM, Michel Jouvin wrote:

It works! Thanks! I've been able to create a PR and check that the
target branch was remembered. I still find discussable that the
"description" is pre-filled with the title: I don't see any reason for
duplicating the tile, nothing prevent the description from being
empty. I'd suggest you mimic the GH behaviour which depends on the
number of commits in the PR:

• 1 commit: the title is pre-filled with the first line of the
  commit description and the description with the remaining lines
• several commits: no default (in fact the branch name which is
  completely useless but ensure there is a non empty title) It also
  seems that there is still one minor problem: the "pull request"
  pane and the "commits", "file changes" remains empty. Any know
  reason for this?

—
Reply to this email directly or view it on GitHub
#29 (comment).

from egit-extensions.

Closing this and opening a new bug for Pre Filling of Description as PR is now successful

from egit-extensions.