Giter VIP home page Giter VIP logo

Comments (3)

acegreen avatar acegreen commented on June 5, 2024

Here is a quick video.

Note: The segue dimisses in a fade like motion which seems to indicate that the dismiss segue works at least somewhat

http://recordit.co/VhRKXOf4BY

from bubbletransition.

acegreen avatar acegreen commented on June 5, 2024

Ah resolved. Migration to Swift 3 caused the method to be named different. The VC still adhered to the UIViewControllerTransitioningDelegate because all methods are optional

@andreamazz maybe consider making the two methods below non-optional?

For future reference

Incorrect method names

    func animationController(forPresentedController presented: UIViewController, presenting: UIViewController, sourceController source: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    }
    func animationController(forDismissed dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    }

Correct method names

    func animationController(forPresented presented: UIViewController, presenting: UIViewController, source: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    }
    func animationController(forDismissed dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    }

from bubbletransition.

andreamazz avatar andreamazz commented on June 5, 2024

The method are define as optionals in UIKit's UIViewControllerTransitioningDelegate, I can't do anything about it 😬

The method names looks correct to me in the current master branch.

from bubbletransition.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.