andreamazz / bubbletransition Goto Github PK

Thanks to the author for the great library, very easy to use, however
I can not run the dismissal effect on ios 9.3 and ios 12. Please check again.
Thank you.

After adding your Framework in "Linked Frameworks and Libraries" I did following:

1. My run script includes
   /usr/local/bin/carthage copy-frameworks
2. Input files
   $(SRCROOT)/Carthage/Build/iOS/BubbleTransition.framework
3. This leaves me with following error:
   

Could it be related to the BubbleTransition.framework.dSYM file?
I found following Issue @Carthage that could be useful: Carthage/Carthage#507

Hi,
First of all thanks for the awesome library
I have added a button and tableview in the presented view. But the button clicks or tableview cell selection are not working.

func animationControllerForDismissedController(dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    transition.transitionMode = .Dismiss
    transition.startingPoint = transitionButton.center
    transition.bubbleColor = transitionButton.backgroundColor!
    return transition
}

Demo project, tested on simulator iOS8.3/iOS8.4 and on iPhone 5s iOS8.4

how can i use with multiple button with difference location?

Hi,

I noticed that the instructions for installing via Cocoapods isn't correct. When using pod 'BubbleTransition', '~> 1.0.0' in a podfile and then doing pod install in the terminal, it pulls an older version written in Swift 2.2. But if I do pod 'BubbleTransition', :git => 'https://github.com/andreamazz/BubbleTransition.git', it pulls the master branch with has the lastest changes in Swift 3.0. Was wondering if it was setup like that on purpose?

I updated the Source Code to Swift 3 but the problem is that the Bubble Transition not working anymore for me :( .

Because newVC.modalPresentationStyle = .custom
so, Is not working

override var preferredStatusBarStyle: UIStatusBarStyle {
        if #available(iOS 13.0, *) {
            return .darkContent
        } else {
            return .default
        }
    }

If oldVC and NewVC have different status bar styles, What should I do?

Hi, friend! Thanks for you great work.
Here is a problem.
The destinationViewController's autolayout doesn't work after I user BubbleTransition to present it.

Can you give me some ideas?

Thanks!

Problem

I use your beautiful control but when you make a presentation to a view controller with autorotate the rotation misses

- (NSUInteger)supportedInterfaceOrientations {
    return UIInterfaceOrientationMaskLandscape;
}

-(BOOL)shouldAutorotate {
    return YES;
}

Can you give me a idea to get this done please?

The warning "The unbalanced calls to begin/end appearance transitions" seems to occur on my UINavigationViewController when i tries to present another controller.

please

• BubbleTransition (~> 1.0.0) required by Podfile

Specs satisfying the BubbleTransition (~> 1.0.0) dependency were found, but they required a higher minimum deployment target.

I came across this error when i was trying to install in through cocoa pods
My minimum deployment target is 9.0

When using navigation bar with Translucent = False the starting point of the animation is calculated wrong.

Check the following video:
https://streamable.com/gs9rn

Check my forked repo to reproduce:
https://github.com/Alexookah/BubbleTransition

changes:
i added a navigation controller as initial vc and changed the translucency in the navigation Bar.

Is there a way to swipe down to dismiss the ModalViewController? If so, how can this be done? Can that be added in a next update? Please let me know, thanks!

I want to add as a child view controller to a container view; is this possible? Because when present a view controller it is displayed on the top above all the other content.

Hi!
Your work is amazing however, i am not into Swift.
I imported your file, created the necessary bridging header and everything compiles, however i don't know how to "activate" the transition and use the delegates. Could you please provide an objective-c example?
Thanks in advance.

Hi, thanks for sharing the great work.
It works well on my project, but my project needs the ability to keep accepting gestures of the user, wondering if this can be done with Bubble Transition?

Hello,

First of all, thank you for sharing your work, it's great!

I would like to know if you ever considered adding an optional UIImage to be used as a bubble background?

It would be a nice improvement I feel.

Cordially,

I would like to use this as a modal menu for presenting options to the user. Something like:

Can you please give me an idea of how I can achieve this?

Good

Hello @andreamazz ,

First of thanks for the great work. Library works awesome.

I'm not sure if my problem is directly linked to bubbleTransition, but I'm noticing a lag on the FIRST button press. From there on after, its smooth as butter.

Note: The startingPoint is incorrect because it appears somewhere on the top though I don't think its CGPointZero but a little under the navigation bar and centered horizontally. This is weird because I specified it as below and that button is at the bottom of the screen. I'm not sure if the button lagged without bubbleTransition.

@IBOutlet var starButton: SpringButton! 

I create the segue using storyboard and just do:

override func prepareForSegue(segue: UIStoryboardSegue, sender: AnyObject?) {
    if segue.identifier == "feedback" {
        let controller = segue.destinationViewController
        controller.transitioningDelegate = self
        controller.modalPresentationStyle = .Custom
    }
}

extension ViewController: UIViewControllerTransitioningDelegate {

func animationControllerForPresentedController(presented: UIViewController, presentingController presenting: UIViewController, sourceController source: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    transition.transitionMode = .Present
    transition.startingPoint = starButton.center
    transition.bubbleColor = UIColor(red: 245.0/255.0, green: 192.0/255.0, blue: 24.0/255.0, alpha: 1)
    return transition
}

func animationControllerForDismissedController(dismissed: UIViewController) -> UIViewControllerAnimatedTransitioning? {
    transition.transitionMode = .Dismiss
    transition.startingPoint = starButton.center
    transition.bubbleColor = UIColor(red: 245.0/255.0, green: 192.0/255.0, blue: 24.0/255.0, alpha: 1)
    return transition
}

}

Now Swift4 has changed the way that Objective-C is called, there needs to be a very minor change to this library.

@objc needs to be added before all of the open vars.

#8

You may have to update your pods.

Hello,

I came across an issue where I refactored my storyboard and am using a storyboard reference. My segue is identical to what it was when I had my VCs in the same storyboard and the transition worked.

Now the bubble transition is not honored and the segue is performed as a regular modal . prepareForSegue is being called and has the following:

if segue.identifier == "FeedbackSegueIdentifier" {            
            let controller = segue.destination
            controller.transitioningDelegate = self
            controller.modalPresentationStyle = .custom
}

With the new storyboard reference I have tried two options

1. Reference to the storyboard and add an intial point of entry
2. Reference the specific UINavigationController in my storboard reference (Reference ID)

Both ignored the transition

especially at this part transition.startingPoint = transitionButton.center

Hi,

I'm running into a problem where transitioningDelegate is set the VC is presented with the custom transition but at some point, the transitioningDelegate is nil and so when its dismissed, the transition is the regular dismiss one.

I understand that transitioningDelegate is a weak property but the VC is not deinit'd as I retain a reference to it in my presenting VC

Note 1: when I check transitioningDelegate in the viewDidLoad() of the presented VC, its the assigned BubbleTransitionDelegate class as expected, but when I'm about to dismiss it, transitioningDelegate is nil

Note 2: the only thing I can think of that I'm doing differently, is that I'm extending UIViewController to have a new present(bubble VC)() method as such:

extension UIViewController {
    func present( bubble viewController: UIViewController, from target: UIView?, presentingColor: UIColor = OMColor.red, dismissingColor: UIColor = OMColor.white, completion: (() -> ())?) {
        
        let bubbleTransitionDelegate = BubbleTransitionDelegate(target: target, presentingColor: presentingColor, dismissingColor: dismissingColor)

        viewController.transitioningDelegate = bubbleTransitionDelegate
        viewController.modalPresentationStyle = .custom
        
        self.present(viewController, animated: true) { 
            completion?()
        }
    }
}

How do I call the transition? I am creating buttons dynamically (in the code) so how do I attach it?

In the demo, the action is directly binding to the storyboard, but when I try to self.present new viewcontroller, the bubble transition won't work, what should I do?

Thanks

It shows Shell in my starred page

i want this in my navigation controller

Are you considering uploading Objective-C code of this transition?

Looks fantastic, by the way!

Thanks for this library! But after I added it to my project using cocoapods, I can't use BubbleInteractiveTransition class. However, I can use BubbleTransition. And I checked "BubbleTransition.swift" file, it seems that there is no BubbleInteractiveTransition class at all. I don't why this happens.

Hi,

When I touch my button with BubbleTransition initiated, there is the bubble animation and it presents the source ViewController and destination ViewController at the same time. Any idea? Thanks.

what should I do if I want to have dismiss direction for presenting non modal controller?

I am using the button inside my Navbar like:

Right bar button -> bar button items -> BubbleBtn

But when I set: transition.startingPoint = BubbleBtn.center it will make the transition start form the very top right corner of my screen:

How can I make it start from the center of the button?

Is there anyway to make it support SpriteKit and scenes?