Variant initialization improvisation (suggestion) about cppinsights HOT 4 OPEN

Hello @amutamil,

thank you for your feedback!

The implementation code you show as it could be isn't valid C++. The second pair of angle brackets is not allowed.

I agree that by default, variant constructs the first type. However, this is an implementation detail of std::variant and is not reflected in the AST. The only thing I see here would be adding a comment with the used initialization value. Sadly, that means that I would have to look for a special type that could also be aliased by, for example, a typedef. I'm not sure this is worth the effort, but I'm happy to accept a patch.

Andreas

from cppinsights.

Hello Andres,
I would like to contribute to this repo,. Am a junior dev guy with just 2 year experience in C++ , proper C++ though just past 3 months :( if any resources explaining the code base or code walk through is available, it would much helpful to start for me.

from cppinsights.

Hello @amutamil,

well, the issue is that C++ Insights uses LLVM/Clang. You need a bit of knowledge there and then find the right entry point for the transformation in C++ Insights. The latter is complex as there is more than just a bare variable declaration. One can also create temporary objects. As I said above, I don't think the feature is worth the effort.

Andreas

from cppinsights.

okay thanks :)

Amutamil E

from cppinsights.