std::move redundant?? about cppinsights HOT 5 CLOSED

Hello @amutamil,

thanks for your feedback!

Without a minimal working example, this is tough to say. In a quick example, I drafted (https://cppinsights.io/s/f4c0dc68), the transformation works as expected.

I'm happy to look at your example.

Andreas

from cppinsights.

Hello @andreasfertig ,

please refer this example https://cppinsights.io/s/647ccf1d,

Regards,
Amutamil E

from cppinsights.

Hello @amutamil,

thanks for sharing the code.

Please have a close look at our two different versions. My struct test comes without a user-provided destructor. As a result, you can see that test, in my case, uses a compiler-provided move constructor (line 5 in the transformed output). Due to the destructor's presence in your example, only a compiler-provided copy constructor exists. This is why there is a cast around the std::move, which adds const.

In short, C++ Insights does what it is supposed to do: show you what's actually happening.

I wrote about this in one of my blog posts: andreasfertig.blog/2023/11/why-you-shouldnt-provide-an-empty-destructor/.

Andreas

from cppinsights.

Hello @andreasfertig,

Sorry if I deviated you from the real bug. I saw that video, from that video only I found this bug,

the real question is after C++ insights translate move into casting also why do we have std::move still being part of the translated version

test(static_cast<const test &&>(std::move(t))); here in last still why we have std::move(t). This can't be just test(static_cast<const test &&>(t));?

Amutamil E

from cppinsights.

Hello @amutamil,

the real question is after C++ insights translate move into casting also why do we have std::move still being part of the translated version

C++ Insights doesn't translate move. I leave STL functions as they are. One reason why I'm not keen to add special code for std::variant. Whatever these functions internally do is part of their implementation.

test(static_cast<const test &&>(std::move(t))); here in last still why we have std::move(t). This can't be just test(static_cast<const test &&>(t));?

As I said above, std::move is not transformed. The cast you see is there because your code is not doing what you expect it to do. The cast C++ Insights shows you is adding const to the rvalue reference the inner std::move returns. If C++ Insights would transform move to a cast, your code would look like this:

test(static_cast<const test &&>(static_cast<test&&>(t)));

Andreas

from cppinsights.