Giter VIP home page Giter VIP logo

meta-grabber's Introduction

sup nerds

meta-grabber's People

Contributors

alexshailoh4 avatar altano avatar andreaswilli avatar dependabot[bot] avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar

meta-grabber's Issues

Display version number in settings

I can not find a way to see which version of the program that I am running.
I might be blind and there is an obvious way if so please enlighten me.

Investigate flaky test case on macOS

Test case change ui language failed on macOS, worked on the second run though.

FAIL tests/app.test.js ([9](https://github.com/andreaswilli/meta-grabber/runs/5168925566?check_suite_focus=true#step:5:9).016 s)
  Home
    โœ“ show initial instructions in snackbar (14 ms)
  Settings
    โœ• change ui language (668 ms)

  โ— Settings โ€บ change ui language

    expect(received).toBe(expected) // Object.is equality

    Expected: "Einstellungen"
    Received: "Settings"

      53 | async function expectText(selector, expectedText) {
      54 |   const actualText = await page.$eval(selector, (el) => el.innerText)
    > 55 |   expect(actualText).toBe(expectedText)
         |                      ^
      56 | }
      57 |

      at _callee6$ (tests/app.test.js:55:22)
      at tryCatch (node_modules/regenerator-runtime/runtime.js:65:40)
      at Generator.invoke [as _invoke] (node_modules/regenerator-runtime/runtime.js:303:22)
      at Generator.prototype.<computed> [as next] (node_modules/regenerator-runtime/runtime.js:117:21)
      at asyncGeneratorStep (tests/app.test.js:7:[10](https://github.com/andreaswilli/meta-grabber/runs/5168925566?check_suite_focus=true#step:5:10)3)
      at _next (tests/app.test.js:9:194)
          at runMicrotasks (<anonymous>)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 passed, 2 total
Snapshots:   0 total
Time:        9.[13](https://github.com/andreaswilli/meta-grabber/runs/5168925566?check_suite_focus=true#step:5:13)8 s
Ran all test suites.
Error: Process completed with exit code 1.

Switch from alphabetical sorting to natural number sorting?

Great app, thank you for making it.

It looks like the sort (and therefore the episode matching) is sub-ideal given the use case of the app. It is using alphabetical sorting and not natural number sorting (https://en.wikipedia.org/wiki/Natural_sort_order), so 1 is followed by 10, and episode 9 is the last one:

image

Ideally, this app could switch to natural number sorting (like macOS' Finder) so it would work without my having to rename the episodes to have 0 padding?

Not pulling all seasons?

There seems to be an issue with the amount of seasons. E.g. currently doing Outlander, there are 6 regular seasons, when pulling up the title in the app it only displays season 0, 1, 2, 3 and 4. Might be a bug, might be something I'm doing wrong, not sure.

Windows: Can't rename

Not sure if I'm doing something wrong but attempting to use this tool on a second drive in windows, in this case D:, doesn't appear to work properly.

Output directory could not be created: Error: ENOENT: no such file or directory, mkdir 'C:\Users\newt\AppData\Local\Programs\meta-grabber\D\media\show\season xx'

This happens with both a specific output dir on the 2nd drive, and blank to leave the files as is
I moved the tool to D: and got the same error with the path starting with the new location of the files.
so this might be an issue with the windows version itself, I was unable to test when both the program and video files are on the same drive however

Creating new folder due to special characters?

I have the output folder setting set to none, but earlier while I was renaming files in a parent folder called "Jeeves & Wooster" a new folder got created called "Jeeves Wooster". So that probably has got to do with the ampersand (although I'm not sure how an an ampersand would cause any issues)?

And now, while doing Cunk on Earth, it created a new folder with the episode title (well, most of it) with a file in it called Off.mkv for the second episode which is called Faith/Off. This one is a lot clearer why it would do that of course, think the forward slash is part of the path (and file names can't contain slashes of course).

So a check for special characters in filenames is probably needed.

Mapping between file names and episodes

I would not like any changes to the mapping between file names and which episode it belongs to for this functionality as I see these as two different things.

I have had some problems with the mappings and would like to now how that works but that should be handled in an other issue

Originally posted by @sterys in #38 (comment)

Second search fail

Hi there,

Thanks for this nice piece of software,

I'm using the appImage version on my Ubuntu x86_64 Linux 5.13

When I rename a folder, everything works as intended, then when I try to rename another folder, I click on the search, click on the same tv shows to select another season, and there it fail and stuck on the loading screen,

Any idea ? or a way to debug or check a log file ?

Thanks

Peek 2021-10-05 17-55

Edit 1 : if I select another tv show the second time & search back the first tv shows, it works... xD

Support for directory in file name template

Hi!
I really like the tool but I think that it would be even better if it supported to give directory in the file name template.

I think that is easier to use and make more sense than having some basic support for template for the output dir which only support one tag at the moment.

For converting series to be as plex want them I could then write

{show_name} ({year})/Seson {season_no}/{show_name} ({year}) - S{season_no} E{episode_no} - {episode_name}

I suggest to support both / and \ as dir separator to work for both windows and linux users.

I also suggest to deprecate the template handling for the output dir since that would no longer be needed.

`Build and Release` Action: run build and release steps only for new versions

Build and release steps are executed for each commit to develop, even if there alredy is a publshed release for the current version number (which means the executables will not be attached to a release draft).

Optimized steps:

  1. run tests
  2. check if published release exists for current version
    • if yes: skip all following steps
    • if no: proceed execution
  3. delete release assets for current version (if release draft exists)
  4. build app and release (i.e. attach to release draft)

Subtitles

I like your program is very fast, but I see a problem does not rename the subtitles .srt, .ssa, .ass. There would be a way for you to include in future versions that renames the subtitles as well? otherwise excellent your work.

TheTVDB.com integration

Hello,

I just found your application and I think it is an awesome tool.
It was working perfectly for a few tv shows but now I have a rather special one it is called:
Rosamunde Pilcher

After searching online it seems that thetvdb.com has an almost complete set of Metadata for the show (142 episodes). TheMovieDB only got 5 or 6.

(I think for tvshows thetvdb is more complete (also in terms of other languages it seems to have more translations out of my experience)

Would it be possible to add thetvdb.com aswell?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.