andreebrazeau / pig_latin Goto Github PK

Hi Andree, i'm doni, you've written a very good, structured and readable code. I really like that. That's
what motivated me to study your code and learning couple of stuff from it.

By the way, i notice a very tiny problem. For words such as kick, mama, noon, peep, deed, did,
recurrency, and mimic in which the first letter appears more than once in a particular word.

I think a conversion for such words to pig-latin is done incorrectly.

For example, if a word is:

kick the answer should be ickkay, not ickay.
noon the answer should be oonnay, not oonay.
mama the answer should be amamay, not aamay.
deed the answer should be eedday, not eeday.
did the answer should be idday, not iday

The problem lies in line 41 in your source code, where the replace takes place. That function(reverse_stem()) should replace the first occurence of a character only once.

By default str.replace replace all occurence of a substring. However that's not what we want. We want to replace the first occurence only.

Here is the correction.
stem = word.replace(prefix, "", 1), it will replace only the first occurence of 'prefix'.