Giter VIP home page Giter VIP logo

Comments (7)

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
Stuart, can you review this?

Original comment by [email protected] on 25 Apr 2012 at 4:11

Attachments:

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
> -  NPDrawingModelCoreAnimation = 3,
> +  NPDrawingModelCoreAnimation = 3, /* DEPRECATED, DO NOT USE */

I disagree pretty strongly with this change; My understanding was that Safari 
never intends to support ICA (since they don't have the implementation 
constraints that make it problematic to support CA), and everyone was okay with 
that, so describing it as deprecated is actively misleading, and will confuse 
plugin vendors.

> +  NPDrawingModelAsyncBitmapSurface = 7,
> +#if defined(XP_WIN)
> +  NPDrawingModelAsyncWindowsDXGISurface = 8
...
> +  , NPNVsupportsAsyncBitmapSurfaceBool = 2005
> +#if defined(XP_WIN)
> +  , NPNVsupportsAsyncWindowsDXGISurfaceBool = 2006

Mismatching the numbers here seems like a very bad idea. I would like to see us 
use 2007 and 2008 here. Not only will this be less potentially confusing, but 
it makes it easy to add support variables for the original types later (just as 
we've needed to add a support variable for QD on the Mac). In fact, it seems 
like it wouldn't hurt to just go ahead and add them now, but I feel much less 
strongly about that than I do about aligning the numbers.

Original comment by stuart.morgan on 3 May 2012 at 2:09

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024

Original comment by stuart.morgan on 3 May 2012 at 2:09

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
I'm on board re: NPDrawingModelCoreAnimation - I'll drop that comment from the 
patch.

Original comment by [email protected] on 3 May 2012 at 3:52

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
Updated patch.

Original comment by [email protected] on 3 May 2012 at 4:08

Attachments:

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024
LGTM, thanks.

Original comment by stuart.morgan on 3 May 2012 at 4:09

from npapi-sdk.

GoogleCodeExporter avatar GoogleCodeExporter commented on July 1, 2024

Original comment by stuart.morgan on 14 Jan 2013 at 9:48

  • Changed state: Fixed

from npapi-sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.