Comments (7)
Stuart, can you review this?
Original comment by [email protected]
on 25 Apr 2012 at 4:11
Attachments:
from npapi-sdk.
> - NPDrawingModelCoreAnimation = 3,
> + NPDrawingModelCoreAnimation = 3, /* DEPRECATED, DO NOT USE */
I disagree pretty strongly with this change; My understanding was that Safari
never intends to support ICA (since they don't have the implementation
constraints that make it problematic to support CA), and everyone was okay with
that, so describing it as deprecated is actively misleading, and will confuse
plugin vendors.
> + NPDrawingModelAsyncBitmapSurface = 7,
> +#if defined(XP_WIN)
> + NPDrawingModelAsyncWindowsDXGISurface = 8
...
> + , NPNVsupportsAsyncBitmapSurfaceBool = 2005
> +#if defined(XP_WIN)
> + , NPNVsupportsAsyncWindowsDXGISurfaceBool = 2006
Mismatching the numbers here seems like a very bad idea. I would like to see us
use 2007 and 2008 here. Not only will this be less potentially confusing, but
it makes it easy to add support variables for the original types later (just as
we've needed to add a support variable for QD on the Mac). In fact, it seems
like it wouldn't hurt to just go ahead and add them now, but I feel much less
strongly about that than I do about aligning the numbers.
Original comment by stuart.morgan
on 3 May 2012 at 2:09
from npapi-sdk.
Original comment by stuart.morgan
on 3 May 2012 at 2:09
from npapi-sdk.
I'm on board re: NPDrawingModelCoreAnimation - I'll drop that comment from the
patch.
Original comment by [email protected]
on 3 May 2012 at 3:52
from npapi-sdk.
Updated patch.
Original comment by [email protected]
on 3 May 2012 at 4:08
Attachments:
from npapi-sdk.
LGTM, thanks.
Original comment by stuart.morgan
on 3 May 2012 at 4:09
from npapi-sdk.
Original comment by stuart.morgan
on 14 Jan 2013 at 9:48
- Changed state: Fixed
from npapi-sdk.
Related Issues (20)
- Need a tutorial or sample code to develop NPAPI Plugin for Safari5.1 from scratch HOT 1
- add a pkgconfig template HOT 6
- Add a simple autotools buildsystem HOT 9
- rev5 breaks API compatibility for plugins HOT 12
- Please add NPAPI_VERSION_REVISION to provide true API version number HOT 2
- add support for NPNVdocumentOrigin HOT 2
- Samples unix-basic BasicPlugin not working HOT 7
- NP_GetPluginVersion has incorrect const-ness HOT 1
- NP_VERSION_MINOR must be increased HOT 1
- Using npapi sdk in browser code. NP_* functions HOT 5
- Const correctness of some functions' arguments HOT 2
- [patch] Can ndata be const void *? Is it used anywhere? HOT 1
- NP_* function declarations are declared with calling convention incompatible with NP_*Func types HOT 3
- Code review request HOT 2
- Fix a calling convention of NPN_* function pointers HOT 11
- Patch for /trunk/samples/mac-basic/Info.plist HOT 1
- Under MinGW bool and uintptr_t are unknown type names HOT 3
- OpenGL.h include in npapi.h on mac is problematic for some users HOT 4
- Plugin compiles but plugin error when loaded
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from npapi-sdk.