Fix a calling convention of NPN_* function pointers about npapi-sdk HOT 11 CLOSED

Ping ?

Why don't you use NP_LOADDS again instead of defining a new macro, NP_CALLBACK?

NP_CALLBACK is already being used in mozilla/dom/plugins/nsNPAPIPlugin.h and 
nsNPAPIPlugin.cpp.

And I moved it from nsNPAPIPlugin.h

Please just use NP_LOADDS. We don't need to worry about what nsNPAPIPlugin does 
here, no need for NP_CALLBACK.

Ok, I've replaced NP_CALLBACK with NP_LOADDS.

If so, we should change nsNPAPIPlugin accordingly to this, later ?

I'm happy with this patch, let's get a look from Stuart Morgan as well though. 
Stuart?

No need to change the Mozilla code here.

I'm not at all familiar with OS/2; what does _System do, and what's the compile 
error this fixes?

_System is the calling convention used for a DLL entry.

And this patch fixes the following case.

----- call.cpp
typedef int (*fnTest)( int, int );

int _System test( int a, int b )
{
    return a + b;
}

int main( void )
{
    fnTest fn = test;

    return fn(10, 10);
}
-----

g++ -c call.cpp generates the following error.

-----
call.cpp: In function 'int main()':
call.cpp:10: error: invalid conversion from 'int (*)(int, int)' to 'int 
(*)(int, int)'
-----

Ping ?

LGTM (although I'm wondering why in all the time the OS/2 define has been 
there, this has never come up before).

As a side note, yay gcc for it's oh-so-helpful error messages.

Committed.