Giter VIP home page Giter VIP logo

Comments (9)

AndyQ avatar AndyQ commented on August 11, 2024

Could you please try the latest version (currently 1.0.10) - There were some fixes in 1.0.9 that may well have fixed this.

from nfcpassportreader.

douglasg avatar douglasg commented on August 11, 2024

Could you please try the latest version (currently 1.0.10) - There were some fixes in 1.0.9 that may well have fixed this.

Yes, I have also tested 1.0.10, with the same result, and then I gradually went down from that version and the last one that works is 1.0.7

from nfcpassportreader.

AndyQ avatar AndyQ commented on August 11, 2024

OK, could you please test the following - let me know if that works:

V1.0.10 - TagReader.swift line 294 - change:
expectedResponseLength : 256
to:
expectedResponseLength : Int(readAmount)

I have a horrible feeling that your passport doesn't handle the unknown amount of data to be read command (256) but could you confirm that that change fixes the issue?

from nfcpassportreader.

douglasg avatar douglasg commented on August 11, 2024

expectedResponseLength : Int(readAmount)

I can confirm that this fixed the problem

from nfcpassportreader.

AndyQ avatar AndyQ commented on August 11, 2024

@douglasg I've created a branch - eofreached with a potential fix. Basically I'm first trying to read an arbitary amount of data (which should fail with your passport). At this point, I drop down to reading smaller chunks.

So you should see the first SOD read fail, it will then redo BAC and retry again which hopefulyl will work.

Could you please test and let me know?

from nfcpassportreader.

SaliienkoOleksandr avatar SaliienkoOleksandr commented on August 11, 2024

expectedResponseLength : Int(readAmount)

I can confirm that this fixed the problem

I also had such problem. Int(Amount) fixed it.

from nfcpassportreader.

SaliienkoOleksandr avatar SaliienkoOleksandr commented on August 11, 2024

Branch - eofreached also works good.

from nfcpassportreader.

douglasg avatar douglasg commented on August 11, 2024

@AndyQ Sorry for the late feedback but I have now tested the branch eofreached and it works

from nfcpassportreader.

AndyQ avatar AndyQ commented on August 11, 2024

@douglasg, @SaliienkoAleksandr - Thanks for testing this! I'll merge it into master and it will be in the next release

from nfcpassportreader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.