andyvn22 / rhythm-game Goto Github PK

Some observations from a fresh clone:

• There are typescript files but no typescript dependency in package.json, should be added to ensure a person trying to contribute to the project gets tsc installed
• README mentions a file named howler/index.d.ts but it does not seem to exist in the repository?
• Perhaps related, trying to compile the project with tsc complains that the Howl type is not found in music.ts
• The .html files link .js files, but the repo is full of .ts files - it would be nice to document in the README how to compile them. Something like npx tsc --rootDir . ?
• There is an Audio/Counts/generate-counts.sh script - is that something one should run at some point to get started developing things locally? Mentioning usage in the README would be nice.

Hi @andyvn22, fun little thing you've made here 👍

Have you considered requesting access to the user's microphone to let the game support real claps and taps?

(Naturally raises the question of how to distinguish "claps" and "taps" and background noise in code.. Should be a bit of a challenge but doable.)