Giter VIP home page Giter VIP logo

vsmodtemplate's Issues

Missing dll file in release

During the creation of my release, I encountered an issue where the release file only contained the following items:

  • assets/
  • modicon.png
  • modinfo.json

The DLL and other necessary files were missing from the release.

Solution:
To resolve this issue, I had to modify the "Package" task in the Program.cs file to include the following lines of code:

// Copy DLL and others
context.CopyFiles($"../{BuildContext.ProjectName}/bin/{context.BuildConfiguration}/Mods/mod/{context.Name}.dll",
    $"../Releases/{context.Name}/");

context.CopyFiles($"../{BuildContext.ProjectName}/bin/{context.BuildConfiguration}/Mods/mod/{context.Name}.deps.json",
    $"../Releases/{context.Name}/");

context.CopyFiles($"../{BuildContext.ProjectName}/bin/{context.BuildConfiguration}/Mods/mod/{context.Name}.pdb",
    $"../Releases/{context.Name}/");

These lines of code ensure that the DLL, dependencies JSON, and PDB files are copied to the release directory. After making these changes, the release file now contains all the necessary files.

modicon is not included in package

When present, the modicon file -- such as modicon.png -- is not packaged with the rest of the mod.

Can be remedied by modifying CakeBuild/Program.cs to include a line similar to the following, but would be nice to have this automatically included in the template for each newly created mod.

context.CopyFile($"../{BuildContext.ProjectName}/modicon.png", $"../Releases/{context.Name}/modicon.png");

Can't setup if VS not in default install path

Vintage Story is installed in C:\Program Files for me, but modtools.exe is searching in (x86).
It then asks me for a custom path, which I provide.
I get and error because it reads it as C:\Program.
So I then use double quotes as is standard, and I get nothing either!

Searching for VS in ""C:\Program Files\Vintagestory"..."

Only way this works is if you don't give up just yet and type :

setup "C:\Program Files\Vintagestory"

Version number

Can we please have the vsmodtemplate to append a version number to the zip file name?
Right now when downloading all it shows is: "vsmodtemplate-master.zip"

[1.15.5] .NetFramework change from 4.5.2 to 4.6.1

Installed Game Version 1.15.5 (stable)

Steps to reproduce issue

Following the guide

  1. Download Project Template 1.5.5
  2. Execute vsmodtools.exe --- run the command "setup"
  3. Compile project in IDE of choice
  • IDE stated that dependencies were compiled using 4.6.1 so it wouldn't compile the template project

Solution

Changed target framework from 4.5.2 to 4.6.1 project compiled and started the game as expected

Setup in custom path gives errors

Searching for VS in "d:\Vintagestory" ...

Something went wrong!
System.NullReferenceException: Object reference not set to an instance of an object.
at vsmodtools.SetupCommand.CheckPath(String path)
at vsmodtools.SetupCommand.Run(String[] args)
at vsmodtools.Program.Main(String[] args)

Ambiguous licensing terms

The GPL-2.0 is incorrectly applied to the template. The only reference to licensing in the template is the LICENSE file which contains a copy of the GPL-2.0 license. The directions in that license file say that a license notice should be placed at the top of every file. The GPL website also says that a license notice should be put at the top of every file. That license notice should declare whether the file is licensed under GPL-2.0, any version of GPL, or GPL-2.0 or later. So in the current state, it is unclear what license the template is under.

Do the Vintage Story game developers want all mods to be open source? The official mod database does not push mod developers to use an open source license. Using a GPL license for the official mod template strongly pushes mode developers into making open source mods. However, if the intention is really for developers to make open source mods, the mod template readme should have directions on how to properly comply with the licensing terms. Most likely many developers are unaware that their mods that use different licenses are violating the licensing terms.

I think that a public domain equivalent license would be more appropriate for a mod template.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.